Continue Improving Event Flows #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serial-ATA
requested changes
Oct 25, 2024
| impl ValueIntoFieldType for String { | ||
| fn into_field_type(self) -> Field<AccountId32> { | ||
| Field::String(BoundedString(BoundedVec( | ||
| self.into_bytes().into_iter().collect(), |
There was a problem hiding this comment.
Suggested change
| self.into_bytes().into_iter().collect(), | |
| self.into_bytes(), |
This should be enough, right?
|
|
||
| if let ResultsKind::Types(ref r) = result { | ||
| if r.is_empty() { | ||
| return Err(input.error("Expected at least one parameter for the `result` attribute, or `_` to infer the type")); | ||
| return Err(input.error("Expected at least one parameter for the `result` attribute, or `_` to infer the type, or nothing to infer the type from the function return type")); |
There was a problem hiding this comment.
Suggested change
| return Err(input.error("Expected at least one parameter for the `result` attribute, or `_` to infer the type, or nothing to infer the type from the function return type")); | |
| return Err(input.error("`result` attribute empty, expected at least one parameter, or `_` to infer the type")); |
The error is getting long, once #381 is being worked on we can use a diagnostic crate and provide that as a hint.
| @@ -51,6 +53,7 @@ gadget-sdk = { path = "./sdk", default-features = false, version = "0.2.2" } | |||
| incredible-squaring-blueprint-eigenlayer = { path = "./blueprints/incredible-squaring-eigenlayer", default-features = false, version = "0.1.1" } | |||
| incredible-squaring-aggregator = { path = "./blueprints/incredible-squaring-eigenlayer/aggregator", default-features = false, version = "0.1.1" } | |||
| periodic-web-poller-blueprint = { path = "./blueprints/periodic-web-poller", default-features = false, version = "0.1.1" } | |||
| tangle-raw-blueprint = { path = "./blueprints/tangle-raw", default-features = false, version = "0.1.1" } | |||
There was a problem hiding this comment.
Suggested change
| tangle-raw-blueprint = { path = "./blueprints/tangle-raw", default-features = false, version = "0.1.1" } | |
| tangle-raw-event-listener-blueprint = { path = "./blueprints/tangle-raw-event-listener", default-features = false, version = "0.1.1" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.