Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ECDSA Public Keys to EVM Addresses when building voters' merkle tree #721

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Convert ECDSA Public Keys to EVM Addresses when building voters' merkle tree #721

merged 6 commits into from
Oct 10, 2023

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Oct 10, 2023 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Ran cargo fmt on the project
  • convert DKGId to Merkle tree leaves using pallet config.
  • update typescript types

Reference issue to close (if applicable)

Closes #720

@shekohex
cargo fmt
457445a
@shekohex
flake.lock: Update
d7dd8f3 
Flake lock file updates:

• Updated input 'flake-utils':
    'github:numtide/flake-utils/cfacdce06f30d2b68473a46042957675eebb3401' (2023-04-11)
  → 'github:numtide/flake-utils/ff7b65b44d01cf9ba6a71320833626af21126384' (2023-09-12)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/8670e496ffd093b60e74e7fa53526aa5920d09eb' (2023-05-01)
  → 'github:NixOS/nixpkgs/2646b294a146df2781b1ca49092450e8a32814e1' (2023-10-08)
• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/07f421299826591e2b28e03bbbe19a5292395afe' (2023-05-02)
  → 'github:oxalica/rust-overlay/c0df7f2a856b5ff27a3ce314f6d7aacf5fda546f' (2023-10-09)
@shekohex
Convert ECDSA Public Keys to EVM Addresses when building the merkle tree
243fc35
1xstj
1xstj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@1xstj 1xstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Needs a bump in Cargo.toml version the spec_version bump does not have an effect since we use the tangle runtime

@shekohex shekohex merged commit af579a3 into master Oct 10, 2023
6 of 7 checks passed
@shekohex shekohex deleted the shady/fix-voters-mt branch October 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@1xstj 1xstj 1xstj approved these changes

@tbraun96 tbraun96 Awaiting requested review from tbraun96 tbraun96 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Merkle Root Calculation using Compressed ECDSA Keys instead of EVM Addresses
3 participants
@shekohex @drewstone @1xstj