-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate multiple signing sets, create signing set IDs #680
Conversation
Partially completed: tangle-network/tangle#207 |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 16.03% 15.80% -0.22%
==========================================
Files 73 76 +3
Lines 5436 5514 +78
==========================================
Hits 871 871
- Misses 4565 4643 +78
☔ View full report in Codecov by Sentry. |
In an effort to increase the probability that signing a proposal succeeds in the event a signer drops off in a signing set, we now spawn 2 signing sets per unsigned proposal. Before SigningManagerV2, we did something similar, except, we did so in response to messages going missing. Now that messages are no longer mysteriously dropping, so long as nodes stay online and are non-malicious, we increase the probability that we converge toward signing completion.