Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LruHashMap over HashMap for pending messages + Other Fixes #673

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

tbraun96
Copy link
Contributor

This PR is an attempt to move us closer to memory stability. As bugs are found they will be fixed here.

@tbraun96 tbraun96 force-pushed the thomas/find-growing-data-structures-part-II branch from 7a7f110 to 982f2fe Compare July 12, 2023 12:43
@tbraun96 tbraun96 changed the title [WIP] Use LruHashMap over HashMap for known messages + Other Fixes [WIP] Use LruHashMap over HashMap for pending messages + Other Fixes Jul 12, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (ca02f61) 16.10% compared to head (6119e68) 16.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   16.10%   16.10%   +0.01%     
==========================================
  Files          73       73              
  Lines        5413     5412       -1     
==========================================
  Hits          871      871              
+ Misses       4542     4541       -1     
Impacted Files Coverage Δ
dkg-gadget/src/gossip_engine/network.rs 0.00% <0.00%> (ø)
...-gadget/src/gossip_messages/misbehaviour_report.rs 0.00% <0.00%> (ø)
dkg-test-orchestrator/src/dummy_api.rs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tbraun96 tbraun96 changed the title [WIP] Use LruHashMap over HashMap for pending messages + Other Fixes Use LruHashMap over HashMap for pending messages + Other Fixes Jul 12, 2023
@tbraun96 tbraun96 merged commit 90bfe77 into master Jul 12, 2023
6 checks passed
@tbraun96 tbraun96 deleted the thomas/find-growing-data-structures-part-II branch July 12, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants