Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement signing for batches of proposals #624

Merged
merged 127 commits into from
Jul 12, 2023
Merged

Implement signing for batches of proposals #624

merged 127 commits into from
Jul 12, 2023

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Jun 4, 2023 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Sign proposals in batches to improve throughput
  • Split dkg-proposal-handler logic to seperate files
  • Update test-suite with new batch updates
  • Update harness with new batch updates
  • Update dkg-gadget with new batch updates
  • Remove delay logic to submit unsigned trasnactions

New flow of proposal signing

Screenshot 2023-06-12 at 9 11 46 PM

Reference issue to close (if applicable)
Closes #578

Thomas Braun and others added 30 commits April 17, 2023 10:44
begin migration of code to new mod
80b2d58
continue impl
a5e36df
get compiling
27729e4
sync
9403336
improve debugging, adjust drop code, continue debugging
06437e1
get first proposalSigned event in ui
d568bc5
@drewstone
Merge branch 'master' into thomas/signing-manager-v2
62d09fe
Merge branch 'master' of https://github.com/webb-tools/dkg-substrate …
87f23df 
…into thomas/signing-manager-v2
wip: wrap blocking calls in async
0576cc9
get rid of mixed synchronous calls in async
c988234
fmt
c83362f
add deadlock detection, more debugging
2a25428
fmt
1a319b9
try fix ts test
c1bb2d9
fmt
2ab6141
wip
9fa51ed
debug
5d1940c
human-readable add event logging
1cd15f4
merge w master
ee3c980
send only last 2 rounds of messages
1f0691f
lints + fixes
5acc78d
@tbraun96
Merge branch 'master' into thomas/signing-manager-v2
166f8f3
lint
7122acb
check rt in debuglogger
27e904c
fix bug in keygen
7457ccb
@1xstj
avoid pushing duplicate signed proposals to offchain storage
412dbb6
@1xstj
remove twitter link
419ed5b
@1xstj
clippy fixes
be852d9
@1xstj
clippy fixes
deca851
@1xstj
limit signing sets and prettify prop hash log
59448b4
@1xstj 1xstj requested review from drewstone and shekohex June 13, 2023 09:47
@1xstj 1xstj added Breaks API needs review 👓 Pull request needs a review labels Jun 19, 2023
@drewstone
Copy link
Contributor

@1xstj we need to also add logic to prevent mixing batches of ResourceIdUpdate proposals with anything else, since they're handled uniquely and not through execute proposal flow.

@1xstj
Copy link
Contributor Author

1xstj commented Jun 30, 2023

Will wait for #652 to merge before merging this, it includes improvements to testing-harness which will help this PR

@devpavan04 devpavan04 mentioned this pull request Jul 3, 2023
Closed
3 tasks
@1xstj 1xstj merged commit ca02f61 into master Jul 12, 2023
6 checks passed
@1xstj 1xstj deleted the batch-proposals branch July 12, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

@tbraun96 tbraun96 Awaiting requested review from tbraun96 tbraun96 is a code owner

@drewstone drewstone Awaiting requested review from drewstone drewstone is a code owner

Assignees
No one assigned
Labels
Breaks API In testnet Being tested in testnet needs review 👓 Pull request needs a review Testnet Passed PR tested in testnet successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPEC] Implement signing for batches of proposals
5 participants
@1xstj @codecov-commenter @drewstone @shekohex @tbraun96