Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File.readable? #250

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Fix File.readable? #250

merged 5 commits into from
Feb 12, 2025

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Feb 10, 2025

No description provided.

@maxirmx maxirmx linked an issue Feb 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.02%. Comparing base (359949a) to head (20f07ec).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/tebako/packager/patch_libraries.rb 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   96.78%   98.02%   +1.23%     
==========================================
  Files          23       23              
  Lines        1246     1264      +18     
==========================================
+ Hits         1206     1239      +33     
+ Misses         40       25      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronaldtse
Copy link
Contributor

Makes me wonder - is it possible to enter a Tebako package interactively and develop my Ruby script inside it? Can I use “irb” from within the Tebako Ruby?

@maxirmx
Copy link
Member Author

maxirmx commented Feb 11, 2025

Makes me wonder - is it possible to enter a Tebako package interactively and develop my Ruby script inside it? Can I use “irb” from within the Tebako Ruby?

Yes, it works on MacOS. You can add bindings.irb to your script, package it and it will enter interactive mode
There is Linux-specific issue that I am fixing with this PR but I can enter irb on my comuter already so it will work

@ronaldtse
Copy link
Contributor

@maxirmx is there a command that we do not need a line binding.irb?

Bundler still offers (the now deprecated) bundle console, which is now just bin/console within your gem.

I wonder if we can allow Tebako to provide access to other executables in the bin/ directory (in addition to automatically entering a defined entrypoint).

e.g.

$ tebako exec my_package.teb bin/console
# Executes bin/console within `my_package.teb`

@maxirmx maxirmx force-pushed the fix-binding-irb branch 3 times, most recently from 74c4dce to 9845129 Compare February 11, 2025 19:01
@maxirmx maxirmx marked this pull request as ready for review February 12, 2025 06:53
@maxirmx maxirmx merged commit b4d1479 into main Feb 12, 2025
143 checks passed
@maxirmx maxirmx deleted the fix-binding-irb branch February 12, 2025 06:53
@maxirmx maxirmx changed the title Fix binding irb Fix File.readable? Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binding.irb crash in tebako package
2 participants