Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provenance coin (HASH) to symbols.py #71

Open
wants to merge 82 commits into
base: master
Choose a base branch
from
Open

Add provenance coin (HASH) to symbols.py #71

wants to merge 82 commits into from

Conversation

llama-del-rey
Copy link

No description provided.

meherett and others added 30 commits May 27, 2021 09:10
@meherett
Merge pull request talonlab#13 from coin-tracker/update-readme
035c717 
Add testing section in readme
@meherett
Merge remote-tracking branch 'origin/master'
a2910a8
@meherett
Update: Testing doc and added development doc.
3869c07
@meherett
Add: Root xpublic key derivation cleaner.
e630169
@meherett
Bump: HDWallet from v1.3.0 to v1.3.1 package.
98b15fd
@martinholy
Fix: Incorrect output of Base58 decoding.
749bf8c
@meherett
Merge pull request talonlab#18 from martinholy/base58_decode_fix
07ace7e 
Fix: Incorrect output of Base58 decoding.
@saloppe73
add ZECTEST
fcb16c7
@saloppe73
update README
697e9e7
@saloppe73
fix LTC/LTCTEST
b876ad4
@meherett
Merge pull request talonlab#19 from saloppe73/master
aeda29b 
add ZECTEST, fix LTC/LTCTEST

Changed -> Litecoin (LTC) mainnet extend private key from `0x019d9cfe` to `0x488ade4` and public key from `0x019da462` to `0x488b21e` prefixes.
@meherett
Update README.md
a480596
@sokripon
Fixed BIP141 link
e79db28 
Corrected the spec link for BIP141.
@meherett
Merge pull request talonlab#23 from sokripon/patch-1
d75afc9 
Fixed BIP141 link
@sokripon
Fixed link for BIP84
78517c5
@sokripon
Fixed link for BIP141
8da78de
@meherett
Merge pull request talonlab#24 from sokripon/patch-1
8a4924a 
Fixed links in readme
@meherett
Bump: HDWallet from v1.3.1 to v1.3.2 package.
71620d2
@meherett
Fix: Zcash symbol ticker and added symbols tester.
0fa4a52
@meherett
Bump: HDWallet from v1.3.1 to v1.3.2 package.
d7488ef
@meherett
Change: Coveralls runner python package version to 3.8
500d840
@meherett
Change: Coveralls runner python form v3.8 to v3.9 package.
3b76caf
@bombs-kim
Added version info
41b6a01
@meherett
Merge pull request talonlab#26 from bombs-kim/master
cd8c4f5 
Added version info
@meherett
Upgrade: Now, from root xprivate and xpublic kes merged into from xpr…
eb1c806 
…ivate and xpublic functions.
@meherett
Update: Removed root key testers and add more tests on from xprv and …
abd7210 
…xpub keys.
@meherett
Update: from_xprivate_key and from_xpublic_key examples.
cdf5d89
@meherett
Add: CLI for hdwallet generator and for millions of addresses generator.
766a75c
@meherett
Drop: Removed first index of space from rows.
25ea8e7
@meherett
Fix: Hardened key for XPublic key on COIN_TYPE keys.
4fe9862
meherett and others added 22 commits December 25, 2021 08:17
@meherett
Fix: Python version 3.10 and setup.py furo package.
dd0e606
@meherett
Drop: Python version 3.10 package.
f5a3fe3
@meherett
Modify: Derivation BIP's initializers tester component.
2439a29
@meherett
Update: Installation documentation for CLI.
56f7642
@meherett
Add: Extras CLI requirements and bump docs packages.
d3b2da3
@meherett
Add: Python version 3.10 package for testing.
206aba9
@meherett
Bump: Python-HDWallet from v2.1.0 to v2.1.1 package.
2a0f710
@meherett
Fix: pythonpackage.yml of pip installation for CLI.
05cb2c1
@meherett
Modify: Python packages and removed some bugs.
7686b85
@meherett
Change: Dist from xenial to bionic package.
84bf856
@XmasApple
Fix: missing quote in language error
09a7b5d
@meherett
Merge pull request talonlab#52 from XmasApple/master
944b07c 
Fix: missing quote in language error
@bracteat
Fix
e524fda 
python3.10 not exists Ripemd160 in hashlib.py
@bracteat
Update hdwallet.py
6ff7c29 
Fix ripemd160 in python3.10
@meherett
Merge pull request talonlab#62 from bracteat/master
86ff8d0 
Fix Ripemd160 in python3.10
@pjkundert
Update from pysha3 (deprecated) to pycryptodome for Keccak-256
15e32d4
@pjkundert
Add test of checksum_encode, using Keccak for ETH addr. upper/lower case
918e33f
@meherett
Merge pull request talonlab#69 from pjkundert/fix-keccak
4c9d2c5 
Update from pysha3 (deprecated) to pycryptodome for Keccak-256
@meherett
Add: Python version 3.11 package for testing.
ca5abd1
@llama-del-rey
Add provenance coin (HASH) to symbols.py
2f63205
@llama-del-rey
rename to nhash
83ca2c9
@llama-del-rey
nope the symbol is HASH
6c8bcbd
@llama-del-rey llama-del-rey mentioned this pull request Nov 10, 2022
Open
4 tasks
@meherett
Copy link
Member

Hi @llama-del-rey, please import Provenance (HASH) wallet protocol https://github.com/meherett/python-hdwallet/blob/master/hdwallet/cryptocurrencies.py here.

@llama-del-rey
Copy link
Author

@meherett thank you for the quick turn around. I was trying to find out the correct values. I have pushed a change. But I am not sure if it is correct 😕

@llama-del-rey
Copy link
Author

Hi @meherett sorry but if and when you can review this please? 🙏

meherett
meherett requested changes Dec 1, 2022
View reviewed changes
hdwallet/cryptocurrencies.py
@@ -2753,6 +2753,44 @@ class HushMainnet(Cryptocurrency):
DEFAULT_PATH = f"m/44'/{str(COIN_TYPE)}/0'/0/0"
WIF_SECRET_KEY = 0x80

class HashMainnet(Cryptocurrency):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer you to change the class from HashMainnet to ProvenanceMainnet name.

hdwallet/cryptocurrencies.py
@@ -2753,6 +2753,44 @@ class HushMainnet(Cryptocurrency):
DEFAULT_PATH = f"m/44'/{str(COIN_TYPE)}/0'/0/0"
WIF_SECRET_KEY = 0x80

class HashMainnet(Cryptocurrency):

NAME = "Hash"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change this one Hash into Provenance name.

hdwallet/cryptocurrencies.py
"P2WSH_IN_P2SH": None
})

MASSAGE_PREFIX = "\x18Bitcoin hash Signed Message:\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the message prefix is Bitcoin signing value, otherwise just set to None value.

hdwallet/cryptocurrencies.py
NAME = "Hash"
SYMBOL = "HASH"
NETWORK = "mainnet"
SOURCE_CODE = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import Provenance github repo link (https://github.com/provenance-io/provenance) into source code.

@meherett
Copy link
Member

meherett commented Dec 1, 2022

@llama-del-rey and also add Provenance cryptocurrency into https://github.com/meherett/python-hdwallet#available-cryptocurrencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meherett meherett meherett requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@llama-del-rey @meherett @martinholy @saloppe73 @sokripon @bombs-kim @alimohammad1995 @XmasApple @bracteat @pjkundert