Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update view_modifiers #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josh-thurston
Copy link

Based on email Michael sent me June 2020. Had to change the response function.

Based on email Michael sent me June 2020.  Had to change the response function.
@mikeckennedy
Copy link
Member

Thanks @josh-thurston ! Remind me about the details of the change you're after there? Also, why object rather than Optional[str] (which is also an improvement on str):

... mimetype: object = None, template_file: object = None ...

@BigMoonTech
Copy link

Dang, dead silence. I wish @josh-thurston would've reminded @mikeckennedy about the purposed change. I'm curious because I have had no problem with the way it is now and I love this design pattern. I have used it in multiple flask projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants