Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add possibility to install cln plugin with coffee #256

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

vincenzopalazzo
Copy link
Contributor

Core lightning is starting to support a decent plugin manager that gives you the possibility to install a plugin without care about the process.

Coffee [1] is a plugin manager that uses the manifest like all basic plugin managers (npm, pacman ...).

So this commit is adding support for coffee and allowing people to install plugins with the following command:

coffee remote add teos-git https://github.com/talaia-labs/rust-teos.git
coffee install rust-teos -v
coffee list

[1] https://github.com/coffee-tools/coffee

@sr-gi
Copy link
Member

sr-gi commented Jul 29, 2024

This is awesome, thanks @vincenzopalazzo.

Sorry for not checking it earlier. Needs rebase

Core lightning is starting to support a decent plugin manager that gives you the possibility to install a plugin without care about the process.

Coffee [1] is a plugin manager that uses the manifest like all basic plugin managers (npm, pacman ...).

So this commit is adding support for coffee and allowing people to install plugins with the following command:

```
coffee remote add teos-git https://github.com/talaia-labs/rust-teos.git
coffee install rust-teos -v
coffee list
```

[1] https://github.com/coffee-tools/coffee
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo
Copy link
Contributor Author

Sorry to be late here @sr-gi, I just rebased it.

Thanks!

@sr-gi
Copy link
Member

sr-gi commented Sep 5, 2024

uTACK 011ba64

Any comments @mariocynicys?

Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK-ish 011ba64

having trouble installing a new lightningd (my current installation is now broke for some reason), but verified that coffee adds watchtower-client as a plugin in the file system.

very neat manager btw :)

@vincenzopalazzo
Copy link
Contributor Author

(my current installation is now broke for some reason)

probably could be some python dependencies?

@sr-gi
Copy link
Member

sr-gi commented Sep 5, 2024

CI also seemed to fail, seems to be related with the cln-grpc rust crate, but I haven't looked closely at it. I may try to spin a virtual machine to compile it and see what's going on

@sr-gi
Copy link
Member

sr-gi commented Sep 5, 2024

Alright, the issue seems to be with the time crate, and it's related to time-rs/time#693

Updating the Cargo.lock for time works, but I guess it'd be best to update whatever package is making cln install a version of time bellow 0.3.36. I'd need to check further for that.

@sr-gi
Copy link
Member

sr-gi commented Sep 5, 2024

This can be merged. The plugin CI issue is fixed here #264

@sr-gi sr-gi merged commit b8a996e into talaia-labs:master Sep 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants