Adds rpccookie to bitcoind auth methods #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr-gi
force-pushed
the
2024-01-authcookie
branch
2 times, most recently
from
c42da84
to
410d45d
Compare
|
work as expected I will provide details of the test comment below |
d6n13l0l1v3r
reviewed
Jan 8, 2024
There was a problem hiding this comment.
this change looks fine, I tested and work as expected details #246 (comment)
There was a problem hiding this comment.
Nice, seems to work for me. Just thought I'd suggest to keep the conf template up to date, maybe with a comment in the # bitcoind section that only one auth method is allowed. https://github.com/talaia-labs/rust-teos/blob/master/teos/src/conf_template.toml
Also the lint error
sr-gi
force-pushed
the
2024-01-authcookie
branch
from
410d45d
to
8377217
Compare
|
Addresses review comments from @orbitalturtle and @mariocynicys |
sr-gi
force-pushed
the
2024-01-authcookie
branch
from
8377217
to
726c4fa
Compare
sr-gi
force-pushed
the
2024-01-authcookie
branch
from
726c4fa
to
900c746
Compare
Currently we are authenticating against bitcoind using user/pass. This adds the option to use a cookie file instead.
sr-gi
force-pushed
the
2024-01-authcookie
branch
from
900c746
to
37a75ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are authenticating against bitcoind using user/pass. This adds the option to use a cookie file instead.
Notice providing the two authentication methods at the same time is not permitted, users must set either the user/pass pair or the cookie file path.
Close #246