Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

630626 - Create Execute Template Action #199

Merged
merged 13 commits into from
May 2, 2024
Merged
170 changes: 170 additions & 0 deletions src/Take.Blip.Builder.UnitTests/Actions/ExecuteTemplateActionTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
using System;
using System.Threading.Tasks;
using HandlebarsDotNet;
using NSubstitute;
using NSubstitute.ExceptionExtensions;
using Serilog;
using Take.Blip.Builder.Actions.ExecuteTemplate;
using Xunit;
using Shouldly;

namespace Take.Blip.Builder.UnitTests.Actions
{
public class ExecuteTemplateActionTests : ActionTestsBase
{
private IHandlebars Handlebars = Substitute.For<IHandlebars>();

private ExecuteTemplateAction GetTarget()
{
return new ExecuteTemplateAction(Handlebars,Substitute.For<ILogger>());
}

[Fact]
public async Task ExecuteTemplateShouldSuccess()
{
//Arrange
var variableName = "TestName";
var outputVariable = "";
Context.GetVariableAsync(nameof(variableName), CancellationToken).Returns(variableName);

var templateResult = "TemplateResult";
var handlebarsTemplate = Substitute.For<HandlebarsTemplate<object, object>>();
handlebarsTemplate(Arg.Any<object>()).Returns("TemplateResult");
Handlebars.Compile(Arg.Any<string>()).Returns(handlebarsTemplate);

var settings = new ExecuteTemplateSettings
{
InputVariables = new []{ nameof(variableName) },
Template = $"Name: {{{{{nameof(variableName)}}}}}",
OutputVariable = outputVariable
};

//Act
var action = GetTarget();
await action.ExecuteAsync(Context, settings, CancellationToken);

// Assert
Handlebars.Received(1).Compile(settings.Template);
await Context.Received(1).SetVariableAsync(Arg.Any<string>(), Arg.Is(templateResult), CancellationToken, Arg.Any<TimeSpan>());
}

[Fact]
public async Task ExecuteTemplateWithObjectAsPropertyShouldSuccess()
{
//Arrange
var variableObj = "{ \"people\": [{\"name\": \"TestName\", \"city\": \"Aracaju\"}, {\"name\": \"TestName2\", \"city\": \"Bahia\"}] }";
var outputVariable = "";
Context.GetVariableAsync(nameof(variableObj), CancellationToken).Returns(variableObj);

var templateResult = "TemplateResult";
var handlebarsTemplate = Substitute.For<HandlebarsTemplate<object, object>>();
handlebarsTemplate(Arg.Any<object>()).Returns("TemplateResult");
Handlebars.Compile(Arg.Any<string>()).Returns(handlebarsTemplate);

var settings = new ExecuteTemplateSettings
{
InputVariables = new []{ nameof(variableObj) },
Template = "Names: {{#each people}}{{name}} living in {{city}} {{/each}}",
OutputVariable = outputVariable
};

//Act
var action = GetTarget();
await action.ExecuteAsync(Context, settings, CancellationToken);

// Assert
Handlebars.Received(1).Compile(settings.Template);
await Context.Received(1).SetVariableAsync(Arg.Any<string>(), Arg.Is(templateResult), CancellationToken, Arg.Any<TimeSpan>());
}

[Fact]
public async Task ExecuteTemplateWithObjectAndStringVariablesAsPropertyShouldSuccess()
{
//Arrange
var variableName = "Peoples:";
var variableObj = "{ \"people\": [{\"name\": \"TestName\", \"city\": \"Aracaju\"}, {\"name\": \"TestName2\", \"city\": \"Bahia\"}] }";
var outputVariable = "";
Context.GetVariableAsync(nameof(variableName), CancellationToken).Returns(variableName);
Context.GetVariableAsync(nameof(variableObj), CancellationToken).Returns(variableObj);

var templateResult = "TemplateResult";
var handlebarsTemplate = Substitute.For<HandlebarsTemplate<object, object>>();
handlebarsTemplate(Arg.Any<object>()).Returns("TemplateResult");
Handlebars.Compile(Arg.Any<string>()).Returns(handlebarsTemplate);
var settings = new ExecuteTemplateSettings
{
InputVariables = new []{ nameof(variableName), nameof(variableObj) },
Template = $"{{{{{nameof(variableName)}}}}} {{{{#each people}}}}{{{{name}}}} living in {{{{city}}}} {{{{/each}}}}",
OutputVariable = outputVariable
};

//Act
var action = GetTarget();
await action.ExecuteAsync(Context, settings, CancellationToken);

// Assert
Handlebars.Received(1).Compile(settings.Template);
await Context.Received(1).SetVariableAsync(Arg.Any<string>(), Arg.Is(templateResult), CancellationToken, Arg.Any<TimeSpan>());
}

[Fact]
public async Task ExecuteTemplateErrorHandlebarsParseShouldFail()
{
//Arrange
var variableName = "TestName";
var outputVariable = "";
Context.GetVariableAsync(nameof(variableName), CancellationToken).Returns(variableName);
Handlebars.Compile("").ThrowsForAnyArgs(new HandlebarsParserException("could not be converted to an expression"));
var settings = new ExecuteTemplateSettings
{
InputVariables = new []{ nameof(variableName) },
Template = $"Name: {{{{nameof(variableName)}}}}",
OutputVariable = outputVariable
};

//Act
var action = GetTarget();
try
{
await action.ExecuteAsync(Context, settings, CancellationToken);
}
catch (HandlebarsParserException ex)
{
ex.Message.ShouldContain("could not be converted to an expression");
}

Handlebars.Received(1).Compile(settings.Template);
await Context.Received(0).SetVariableAsync(Arg.Any<string>(), Arg.Any<string>(), CancellationToken, Arg.Any<TimeSpan>());
}

[Fact]
public async Task ExecuteTemplateErrorHandlebarsExecutionShouldFail()
{
//Arrange
var variableName = "TestName";
var outputVariable = "";
Context.GetVariableAsync(nameof(variableName), CancellationToken).Returns(variableName);
Handlebars.Compile("").ThrowsForAnyArgs(new Exception("Error executing the template"));
var settings = new ExecuteTemplateSettings
{
InputVariables = new []{ nameof(variableName) },
Template = $"Name: {{{{nameof(variableName)}}}}",
OutputVariable = outputVariable
};

//Act
var action = GetTarget();
try
{
await action.ExecuteAsync(Context, settings, CancellationToken);
}
catch (Exception ex)
{
ex.Message.ShouldContain("Error executing the template");
}

Handlebars.Received(1).Compile(settings.Template);
await Context.Received(0).SetVariableAsync(Arg.Any<string>(), Arg.Any<string>(), CancellationToken, Arg.Any<TimeSpan>());
}
}
}
103 changes: 103 additions & 0 deletions src/Take.Blip.Builder/Actions/ExecuteTemplate/ExecuteTemplateAction.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
using System;
using System.Threading;
using System.Threading.Tasks;
using Esprima;
using HandlebarsDotNet;
using Lime.Protocol;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using Serilog;
using Take.Blip.Builder.Utils;
using Takenet.Iris.Messaging;

namespace Take.Blip.Builder.Actions.ExecuteTemplate
{
public class ExecuteTemplateAction : ActionBase<ExecuteTemplateSettings>
{
private readonly ILogger _logger;
private readonly IHandlebars _handlebars;

public ExecuteTemplateAction(IHandlebars handlebars, ILogger logger) : base(nameof(ExecuteTemplateAction))
{
_logger = logger;
_handlebars = handlebars;
}

public override async Task ExecuteAsync(IContext context, ExecuteTemplateSettings settings, CancellationToken cancellationToken)
{
var result = string.Empty;
try
{
var arguments = await GetScriptArgumentsAsync(context, settings, cancellationToken);
var obj = CopyArgumentsToObject(arguments);
var template = _handlebars.Compile(settings.Template);
result = template(obj);
}
catch (Exception ex)
{
if (ex is HandlebarsParserException)
{
_logger.Warning(ex, "Unexpected error while trying to parse Handlebars template");
throw;
}

_logger.Warning(ex, "Unexpected error while execute action Execute Template");
throw;
}

await SetScriptResultAsync(context, settings, result, cancellationToken);
}

private async Task<JObject> GetScriptArgumentsAsync(
IContext context, ExecuteTemplateSettings settings, CancellationToken cancellationToken)
{
var obj = new JObject();

if (settings.InputVariables.IsNullOrEmpty())
{
return obj;
}

foreach (var variable in settings.InputVariables)
{
var variableValue = await context.GetVariableAsync(variable, cancellationToken);
obj[variable] = variableValue;
}
return obj;
}

private async Task SetScriptResultAsync(
IContext context, ExecuteTemplateSettings settings, string result, CancellationToken cancellationToken)
{
if (result.IsNullOrEmpty())
{
await context.DeleteVariableAsync(settings.OutputVariable, cancellationToken);
}
else
{
await context.SetVariableAsync(settings.OutputVariable, result, cancellationToken);
}
}

private JObject CopyArgumentsToObject(JObject arguments)
danteveloso marked this conversation as resolved.
Show resolved Hide resolved
{
var obj = new JObject();
foreach (var property in arguments.Properties())
{
try
{
var deserializedJson = JsonConvert.DeserializeObject<JObject>(property.Value.ToString(), JsonSerializerSettingsContainer.Settings);
if (deserializedJson != null)
{
obj.Merge(deserializedJson);
}
} catch (JsonReaderException)
{
obj[property.Name] = property.Value;
}
}

return obj;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
using System.ComponentModel.DataAnnotations;
using Take.Blip.Builder.Models;

namespace Take.Blip.Builder.Actions.ExecuteTemplate
{
/// <summary>
/// Settings to Execute Template Action
/// </summary>
public class ExecuteTemplateSettings : IValidable
{
/// <summary>
/// Input Variables
/// </summary>
public string[] InputVariables { get; set; }

/// <summary>
/// Output Variable
/// </summary>
public string OutputVariable { get; set; }

/// <summary>
/// Template that will be transformed
/// </summary>
public string Template { get; set; }

public void Validate()
{
if (string.IsNullOrEmpty(OutputVariable))
{
throw new ValidationException($"The '{nameof(OutputVariable)}' settings value is required for '{nameof(ExecuteTemplateSettings)}' action");
}
}
}
}
4 changes: 3 additions & 1 deletion src/Take.Blip.Builder/Hosting/ContainerExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using Take.Blip.Builder.Actions.CreateTicket;
using Take.Blip.Builder.Actions.DeleteVariable;
using Take.Blip.Builder.Actions.ExecuteScript;
using Take.Blip.Builder.Actions.ExecuteTemplate;
using Take.Blip.Builder.Actions.ManageList;
using Take.Blip.Builder.Actions.MergeContact;
using Take.Blip.Builder.Actions.ProcessCommand;
Expand Down Expand Up @@ -95,7 +96,8 @@ private static Container RegisterBuilderActions(this Container container)
typeof(CreateTicketAction),
typeof(DeleteVariableAction),
typeof(ProcessContentAssistantAction),
typeof(TrackContactsJourneyAction)
typeof(TrackContactsJourneyAction),
typeof(ExecuteTemplateAction)
});

return container;
Expand Down
2 changes: 2 additions & 0 deletions src/Take.Blip.Builder/Take.Blip.Builder.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Handlebars.Net.Extension.Json" Version="1.0.0" />
<PackageReference Include="SimpleInjector" Version="5.4.1" />
<PackageReference Include="System.ComponentModel.Annotations" Version="4.4.0" />
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="4.10.0" />
<PackageReference Include="Take.Elephant" Version="0.10.2" />
<PackageReference Include="Take.Jint.Unnoficial" Version="4.0.4" />
<PackageReference Include="TimeZoneConverter" Version="3.4.0" />
<PackageReference Include="Handlebars.Net" Version="2.1.6" />
</ItemGroup>

<ItemGroup>
Expand Down