upgrade deps #2
Closed
upgrade deps #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sisu to 0.3.3 - guice to 4.0, and removing sisu-guice - guice-servlet to 4.0 - guava to 19.0
|
So I should have looked before; but I didn't see this when I implemented same thing: This may actually be better, if setting this flag is the new way which seems like it might be since the other branch of that if has comments suggesting its for RestEASY 2.x compat. Though this probably should be wrapped in ComponentContainerImpl, the core SiestaServlet shouldn't need to know any details about the RestEASY impl; thats part of the point of Siesta to create a normalized means to mount a JAX-RS application w/o any of the JAX-RS impl detail. So it would make more sense to auto-set that init-param here: Its also unfortunate RestEASY is more easily configurable here, but... we hack-n-dance as needed :-] |
|
Merged into #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1
Upgrades resteasy to 3.1.x, switches the project to java 8