Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roborazzi.compare.output.dir gradle.properties #592

Merged

Conversation

takahirom
Copy link
Owner

@takahirom takahirom commented Dec 6, 2024

Behavior Changes to roborazzi.outputDir.set(file("somedir")) in build.gradle

Previously, when modifying roborazzi.outputDir, such as setting it to src/screenshots, this option also affected the paths for comparison images, like foo_compare.png. This behavior often caused issues, such as unintentionally saving comparison images to version control systems (e.g., Git). To address this, we have discontinued this behavior. Comparison images are now saved in build/outputs/roborazzi by default, while the behavior for reference images remains unchanged.

For users who wish to customize the path for comparison images, we have introduced a new option: roborazzi.compare.outputDir.

While I don't believe there are strong use cases for this, if you want to save the comparison images in a custom directory as you did before, you can specify roborazzi.compare.outputDir as follows:

roborazzi {
  outputDir.set(file("src/screenshots"))
  compare {
    outputDir.set(file("src/screenshots"))
  }
}

I believe this adjustment will be highly beneficial for most use cases involving changes to outputDir.

Note

By default, when you use captureRoboImage("image.png"), the image will be saved as module/image.png.
You can customize the file path strategy for the recorded image. The default strategy is relativePathFromCurrentDirectory. If you select relativePathFromRoborazziContextOutputDirectory, the file will be saved in the output directory specified by roborazzi.outputDir.
This can be configured in your gradle.properties file:

roborazzi.record.filePathStrategy=relativePathFromRoborazziContextOutputDirectory

@takahirom
Copy link
Owner Author

takahirom commented Dec 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@takahirom takahirom marked this pull request as ready for review December 6, 2024 13:30
@takahirom takahirom force-pushed the 12-06-add_roborazzi.compare.output.dir_gradle.properties branch from 9ed4b4e to a9f33fa Compare December 7, 2024 09:30
@takahirom takahirom force-pushed the 12-06-add_roborazzi.compare.output.dir_gradle.properties branch 4 times, most recently from 19f993e to ea2b4ca Compare December 7, 2024 14:19
@takahirom takahirom force-pushed the 12-06-add_roborazzi.compare.output.dir_gradle.properties branch from ea2b4ca to d1d9515 Compare December 8, 2024 02:48
@takahirom
Copy link
Owner Author

takahirom commented Dec 9, 2024

Merge activity

  • Dec 9, 12:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 9, 12:09 AM EST: A user merged this pull request with Graphite.

@takahirom takahirom merged commit 0c2a00b into main Dec 9, 2024
7 checks passed
@takahirom takahirom deleted the 12-06-add_roborazzi.compare.output.dir_gradle.properties branch December 9, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant