Add the ability to change File writers and readers and add support for lossless WebP #529
Conversation
takahirom
force-pushed
the
takahirom/support-lossless-webp/2024-11-01
branch
from
aab7c28 to
2dabf4c
Compare
takahirom
changed the title
| } | ||
|
|
||
| /** | ||
| * Add testImplementation("io.github.darkxanter:webp-imageio:0.3.0") to use this |
There was a problem hiding this comment.
every1 who wants to use webp format should add this?
is so, why not adding it as transitive dependency?
There was a problem hiding this comment.
Thanks, that makes sense. However, since we need to download additional code when using this, there are trade-offs to consider. Additionally, the roborazzi-core module is already being utilized by the Roborazzi Gradle Plugin. While we may need to add the roborazzi-webp module, it could complicate maintenance. This is why I'm using a compileOnly dependency. It would be beneficial to add a comment explaining the compileOnly dependency.
There was a problem hiding this comment.
makes sense, yeah
should be enough for now to have it in readme
There was a problem hiding this comment.
I forgot to include this in the README. Thank you.
takahirom
merged commit ccb4154
into
takahirom/extension-changeable/2024-10-31
close #522