Skip to content

Commit

Permalink
Apply suppressions to AccessibilityViewCheckResult
Browse files Browse the repository at this point in the history
This change introduces a new `applySuppressions` function to process suppressions for accessibility check results.
It filters results based on suppression rules and adds a new `AccessibilityCheckResultType.SUPPRESSED` type for suppressed results.
Additionally, it adds logging for suppressed results.
  • Loading branch information
yschimke committed Nov 23, 2024
1 parent b053133 commit e60a066
Showing 1 changed file with 17 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,20 @@ data class RoborazziATFAccessibilityChecker(

val results = viewChecker.runChecksOnView(ImmutableSet.copyOf(checks), view, parameters)

return results.filter {
!suppressions.matches(it)
return results.applySuppressions(suppressions)
}

private fun List<AccessibilityViewCheckResult>.applySuppressions(
suppressions: Matcher<in AccessibilityViewCheckResult>
): List<AccessibilityViewCheckResult> {
val ranTypes = listOf(
AccessibilityCheckResultType.ERROR,
AccessibilityCheckResultType.WARNING,
AccessibilityCheckResultType.INFO
)

return map {
if (suppressions.matches(it) && ranTypes.contains(it.type)) it.suppressedResultCopy else it
}
}

Expand All @@ -191,6 +203,9 @@ data class RoborazziATFAccessibilityChecker(
AccessibilityCheckResultType.WARNING -> roborazziErrorLog(
"Warning: $check"
)
AccessibilityCheckResultType.SUPPRESSED -> roborazziReportLog(
"Suppressed: $check"
)

AccessibilityCheckResultType.INFO -> roborazziReportLog(
"Info: $check"
Expand Down

0 comments on commit e60a066

Please sign in to comment.