Merge pull request #640 from takahirom/takahirom/fix-AssertionImageTy…

…pe-api/2025-01-24 Use Actual image instead of Reference image for image assertion
takahirom · Jan 24, 2025 · ab6ba5d · ab6ba5d
2 parents 0d074fe + ffa5e84
commit ab6ba5d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...roborazzi-core/src/commonMain/kotlin/com/github/takahirom/roborazzi/AiAssertionOptions.kt b/...roborazzi-core/src/commonMain/kotlin/com/github/takahirom/roborazzi/AiAssertionOptions.kt
@@ -9,7 +9,7 @@ data class AiAssertionOptions(
   val aiAssertions: List<AiAssertion> = emptyList(),
   val assertionImageType: AssertionImageType = AssertionImageType.Comparison(),
   val systemPrompt: String = when (assertionImageType) {
-    is AssertionImageType.Reference -> """Evaluate the new image's fulfillment of the user's requirements.
+    is AssertionImageType.Actual -> """Evaluate the new image's fulfillment of the user's requirements.
 The assessment should be based solely on the provided reference image 
 and the user's input specifications. Focus on whether the new image 
 meets all functional and design requirements.
@@ -60,7 +60,7 @@ INPUT_PROMPT
 
   sealed interface AssertionImageType {
     class Comparison : AssertionImageType
-    class Reference : AssertionImageType
+    class Actual : AssertionImageType
   }
 
   data class AiAssertion(

diff --git a/...razzi-ai-gemini/src/commonMain/kotlin/com/github/takahirom/roborazzi/GeminiRoborazziAi.kt b/...razzi-ai-gemini/src/commonMain/kotlin/com/github/takahirom/roborazzi/GeminiRoborazziAi.kt
@@ -65,7 +65,7 @@ class GeminiAiAssertionModel(
     val inputPrompt = aiAssertionOptions.inputPrompt(aiAssertionOptions)
     val imageFilePath = when (aiAssertionOptions.assertionImageType) {
       is AiAssertionOptions.AssertionImageType.Comparison -> comparisonImageFilePath
-      is AiAssertionOptions.AssertionImageType.Reference -> referenceImageFilePath
+      is AiAssertionOptions.AssertionImageType.Actual -> actualImageFilePath
     }
     val inputContent = content {
       image(readByteArrayFromFile(imageFilePath))

diff --git a/...-ai-openai/src/commonMain/kotlin/com/github/takahirom/roborazzi/OpenAiAiAssertionModel.kt b/...-ai-openai/src/commonMain/kotlin/com/github/takahirom/roborazzi/OpenAiAiAssertionModel.kt
@@ -71,7 +71,7 @@ class OpenAiAiAssertionModel(
     val inputPrompt = aiAssertionOptions.inputPrompt(aiAssertionOptions)
     val imageFilePath = when (aiAssertionOptions.assertionImageType) {
       is AiAssertionOptions.AssertionImageType.Comparison -> comparisonImageFilePath
-      is AiAssertionOptions.AssertionImageType.Reference -> referenceImageFilePath
+      is AiAssertionOptions.AssertionImageType.Actual -> actualImageFilePath
     }
     val imageBytes = readByteArrayFromFile(imageFilePath)
     val imageBase64 = imageBytes.encodeBase64()