Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve timeout and performance issues in buffer write mode and AOF writes #893

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

EquentR
Copy link
Collaborator

@EquentR EquentR commented Nov 29, 2024

fix: resolve timeout and performance issues in buffer write mode and AOF writes

  • resolve timeout issue after small-batch writes in buffer mode

  • address high disk usage and write bottleneck caused by forced AOF file sync

  • 解决redis_writer缓冲区模式下小批量写入后的超时不提交问题

  • 解决强制AOF文件同步导致的磁盘占用高和写入瓶颈问题

…AOF writes

- resolve timeout issue after small-batch writes in buffer mode
- address high disk usage and write bottleneck caused by forced AOF file sync
Copy link
Member

@suxb201 suxb201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 更倾向于原先写法一点,新的改动带来高延迟风险。
  2. 后续有机会可以把 sendCount 改成 sendBytes,flush 不在意 count,只在意 bytes;也能避免 100 条大命令导致 OOM 的场景。

internal/client/redis.go Show resolved Hide resolved
- Trigger flush based on 64k data size instead of packet count
- Improve timer reset mechanism to minimize latency under high load

feat: enhance RDB file receiving logs
- Add log to display the current received RDB size in real-time
@suxb201 suxb201 self-requested a review December 3, 2024 08:16
@suxb201 suxb201 merged commit 5cea294 into tair-opensource:v4 Dec 3, 2024
6 checks passed
@EquentR EquentR deleted the fix-buff branch December 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants