Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Symbol.dispose and Symbol.asyncDispose are available #15404

Merged
merged 5 commits into from
Dec 16, 2024
+13 −2
Merged

Ensure Symbol.dispose and Symbol.asyncDispose are available #15404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ce4738
fix small type issue
RobinMalfait Dec 16, 2024
6a2e05e
tmp: use Node 18 in CI, to make tests fail
RobinMalfait Dec 16, 2024
1d09d20
polyfill `Symbol.dispose` and `Symbol.asyncDispose`
RobinMalfait Dec 16, 2024
6b5935b
Revert "tmp: use Node 18 in CI, to make tests fail"
RobinMalfait Dec 16, 2024
fa868a6
update changelog
RobinMalfait Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Nothing yet!
### Fixed

- Ensure `Symbol.dispose` and `Symbol.asyncDispose` are polyfilled ([#15404](https://github.com/tailwindlabs/tailwindcss/pull/15404))

## [4.0.0-beta.7] - 2024-12-13

Expand Down Expand Up @@ -763,3 +765,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Move the CLI into a separate `@tailwindcss/cli` package ([#13095](https://github.com/tailwindlabs/tailwindcss/pull/13095))

## [4.0.0-alpha.1] - 2024-03-06

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, was removed in some previous PR for some reason.

I think we should actually just add an empty placeholder or remove this empty header 😅

10 changes: 9 additions & 1 deletion packages/@tailwindcss-node/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
import { DefaultMap } from '../../tailwindcss/src/utils/default-map'
import * as env from './env'

// See: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html#:~:text=Symbol.dispose,-??=%20Symbol(%22Symbol.dispose
// @ts-expect-error — Ensure Symbol.dispose exists
Symbol.dispose ??= Symbol('Symbol.dispose')
// @ts-expect-error — Ensure Symbol.asyncDispose exists
Symbol.asyncDispose ??= Symbol('Symbol.asyncDispose')

export class Instrumentation implements Disposable {
#hits = new DefaultMap(() => ({ value: 0 }))
#timers = new DefaultMap(() => ({ value: 0n }))
#timerStack: { id: string; label: string; namespace: string; value: bigint }[] = []

constructor(private defaultFlush = (message: string) => process.stderr.write(`${message}\n`)) {}
constructor(
private defaultFlush = (message: string) => void process.stderr.write(`${message}\n`),
) {}

hit(label: string) {
this.#hits.get(label).value++
Expand Down