android: refine search results page #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally deleted a }
…ri/search # Conflicts: # android/src/main/java/com/tailscale/ipn/ui/viewModel/MainViewModel.kt
The Material3 search bar doesn't open up a full screen view, but opens a view underneath the bar. To accomplish the full screen search page, we create a new SearchView and use a decoy search bar on the main view that navigates the user to the SearchView Tapping on a search suggestion / result navigates to the PeerDetails, so this also updates the navigation for PeerDetails to use a back stack instead of always navigating back to the main screen Updates tailscale/corp#18973 Signed-off-by: kari-ts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use device name for headline, and user name as metadata
Fix spacing so that arrow aligns with back arrow
Add dividers