Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spotify http guide #87

Closed
wants to merge 7 commits into from

Conversation

rajdip-b
Copy link
Contributor

No description provided.

@rajdip-b rajdip-b marked this pull request as draft January 15, 2024 09:54
@rajdip-b rajdip-b marked this pull request as ready for review January 18, 2024 16:34
Yet another example of fetching, this time, we will shift our focus on how we can handle pagination with Tailcall. The `tracks` field of the `Album` type returns a `TrackPage` type. This type is an implementation of the `Page` interface. The `Page` interface is implemented by both `TrackPage` and `AlbumPage` types. This allows us to use the `Page` interface as a return type for our `tracks` field. This is how the query schema looks like:

```graphql showLineNumbers
getTracksOfAlbum(id: String!, limit: Int!, offset: Int!, accessToken: String!): TrackPage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This is not valid GraphQL syntax.
  2. We should use @http on the tracks field of Album so that we can see a relation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tusharmath would you let me know what's not correct about the GraphQL syntax? I'm not sure I fully understand the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a directive, it needs to be attached to some type.

@tusharmath
Copy link
Contributor

@rajdip-b Let me know if you are still on this.

@rajdip-b
Copy link
Contributor Author

Hey @tusharmath, yes I'm still available for this. Was totally occupied yesterday. I'm planning to get started with the changes from today.

@tusharmath
Copy link
Contributor

@rajdip-b Closing this for now. Please feel free to reopen when you think it's ready.

@tusharmath tusharmath closed this Mar 15, 2024
@rajdip-b
Copy link
Contributor Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants