More features #74
Merged
More features #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add assets, constants and types
GreaterThanUnderscoreIcon
vvu060
requested review from
amitksingh1490,
tusharmath and
rajatbarman
and removed request for
tusharmath
Comment on lines
+11
to
+26
| --ifm-color-yellow: #fdea2e; | ||
| --ifm-color-black: #000; | ||
| --ifm-color-dark: #323335; | ||
| --ifm-color-dark-800: #121315; | ||
| --ifm-color-dark-900: #2c2c2c; | ||
| --ifm-color-white: #ffffff; | ||
| --ifm-color-gray-300: #f3f4f7; | ||
| --ifm-color-gray-400: #e4e4e4; | ||
| --ifm-color-gray-500: #e5e5e5; | ||
| --ifm-color-gray-600: #e7e7e7; | ||
| --ifm-color-gray-700: #cececf; | ||
| --ifm-color-gray-800: #b6b6b7; | ||
| --ifm-color-linkedin: #0a66c2; | ||
| --ifm-color-discord: #5865f2; | ||
| --ifm-color-white-opacity-15: rgba(255, 255, 255, 0.15); | ||
| --ifm-color-black-opacity-05: rgba(0, 0, 0, 0.05); |
There was a problem hiding this comment.
Please give better names like primary, secondary, base etc.
Brand color should be yellow
There was a problem hiding this comment.
There was a problem hiding this comment.
Hey Amit most of the important colors(primary, secondary) are in tailwind config which are named correctly. These gray colors are used only in few places and they are gray colors so I have kept the names like this.
amitksingh1490
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.