Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSS equivalent of grid-dark image #421

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Aug 4, 2024

Closes #418
/claim #418

@algora-pbc algora-pbc bot mentioned this pull request Aug 4, 2024
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 4, 2024

@tusharmath PR ready for review
image

image

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 4, 2024

Currently the format:fix and format:check commands dosen't format the CSS files, lemme know if I should add that in this PR too.

@amitksingh1490 amitksingh1490 marked this pull request as draft August 5, 2024 13:13
@amitksingh1490
Copy link
Contributor

I've noticed a few differences between the two implementations:

  1. Grid Size: The grid size in the CSS version appears slightly different compared to the background image version.

  2. Dot Visibility: The intersections of the horizontal and vertical lines in the CSS version have noticeable thick dots, which are not present in the image version.

  3. Line Visibility: The lines in the CSS version are less visible compared to those in the image version.

Here is side by side comparison
Left has CSS
Right has bg image
image

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 5, 2024

I've noticed a few differences between the two implementations:

  1. Grid Size: The grid size in the CSS version appears slightly different compared to the background image version.
  2. Dot Visibility: The intersections of the horizontal and vertical lines in the CSS version have noticeable thick dots, which are not present in the image version.
  3. Line Visibility: The lines in the CSS version are less visible compared to those in the image version.

Here is side by side comparison Left has CSS Right has bg image image

@amitksingh1490 I've tried to bring them as close as possible

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 5, 2024

image

@35C4n0r 35C4n0r marked this pull request as ready for review August 5, 2024 17:42
@amitksingh1490 amitksingh1490 enabled auto-merge (squash) August 7, 2024 13:19
This was referenced Aug 7, 2024
@amitksingh1490 amitksingh1490 merged commit 764a14f into tailcallhq:develop Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop grid-dark.png
2 participants