Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build & write-good errors #109

Merged
merged 7 commits into from
Feb 19, 2024
Merged

fix: build & write-good errors #109

merged 7 commits into from
Feb 19, 2024

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Feb 8, 2024 •
edited
Loading

This PR fixes failing build caused by react-lottie, by loading the dependency dynamically and write-good lint errors.

/closes #107
/claim #107

@algora-pbc algora-pbc bot mentioned this pull request Feb 8, 2024
Closed
@tusharmath
Copy link
Contributor

@neo773 are you still on this?

@neo773
Copy link
Contributor Author

neo773 commented Feb 15, 2024

@tusharmath
Fixed the remaining write-good errors, there's still a few of these errors though
The `@modify` operator in GraphQL ^^^^^^ "modify" is wordy or unneeded on line 5 at column 6
the cli doesn't seem to support excluding words

@tusharmath tusharmath merged commit c6e2c81 into tailcallhq:develop Feb 19, 2024
2 checks passed
@tusharmath
Copy link
Contributor

/tip 100$

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 19, 2024

👉 @tusharmath: Navigate to your dashboard to proceed

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 19, 2024

🎉🎈 @neo773 has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: write-good lint errors
2 participants
@neo773 @tusharmath