fix: use arduino/setup-protocol #1370
Conversation
WalkthroughThe update involves modifying continuous integration (CI) workflows by adopting Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
the
type: fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
+ Coverage 88.21% 88.36% +0.14%
==========================================
Files 128 128
Lines 13407 13385 -22
==========================================
Hits 11827 11827
+ Misses 1580 1558 -22 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/ci.yml (3 hunks)
- .github/workflows/lint.yml (1 hunks)
Additional comments: 4
.github/workflows/lint.yml (1)
- 36-37: The switch to
arduino/setup-protoc@v3for installing Protoc is a significant change aimed at improving the toolchain setup. Please ensure that this version is fully compatible with the project's requirements and does not introduce any performance regressions or breaking changes.Consider adding a step to verify the compatibility of
arduino/setup-protoc@v3with the project's Protobuf files to ensure smooth integration..github/workflows/ci.yml (3)
- 58-59: Switching to
arduino/setup-protoc@v3for the AWS Lambda build process is a notable update. Ensure compatibility with the project's Protobuf files and assess any impact on the build performance.Consider adding a verification step for
arduino/setup-protoc@v3compatibility with the project's Protobuf files, especially for AWS Lambda builds.
- 103-104: The update to use
arduino/setup-protoc@v3in the general test job is crucial for maintaining a consistent toolchain across the project. As with other changes, verify this version's compatibility and performance impact on the testing process.Adding a step to confirm the compatibility of
arduino/setup-protoc@v3with the project's Protobuf files in the testing context is recommended.
- 135-136: Implementing
arduino/setup-protoc@v3for the examples check job is a strategic move to ensure the toolchain's uniformity. Confirm that this version aligns with the project's Protobuf requirements and does not negatively affect the build or check process.It's advisable to verify the compatibility of
arduino/setup-protoc@v3with the Protobuf files used in examples to ensure a seamless integration.
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
@neo closing this PR because the build does not work in Windows env. |
|
More insights about the issues can be found here #1380 |
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #1360
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check./claim #1360