Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

1559 only txlist rlp decode #143

Open
wants to merge 32 commits into
base: taiko/pi-refactor
Choose a base branch
from

Conversation

smtmfft
Copy link
Collaborator

@smtmfft smtmfft commented Aug 24, 2023

RLP decoding circuit for txlist. It supports both correct rlp bytes and incorrect rlp bytes.
Design doc: https://www.notion.so/taikoxyz/RLP-circuit-design-doc-e59ddfda4b5a40e6ac0f170f23154ed8

So far the majority decoding logic seems ok, rest jobs are:

TODOs:

  • lookup to keccak table to insure txlist input, which may also involve hi-lo change.
  • design output params (maybe a lookup table??) for other circuits.
  • logic completeness check, for valid bytes at least.
  • constraint refactory using circuit-tool.
  • lookup refactory using circuit-tool
  • more test coverage, especially for invalid cases.
  • 1559 tx type support, with or without legacy depends on future design.

smtmfft and others added 30 commits August 22, 2023 11:37
@smtmfft
Copy link
Collaborator Author

smtmfft commented Aug 24, 2023

I based my PR on cecilia's PI refactory branch, where circuit tool is not align with latest MPT in PSE, so some features are missing, using plain code instead.
Lookup seems highly coupled with cell manager, so refactory takes longer time, so far still using traditional lookup api.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant