Circuit tools #123

…kup fix in branch_rlc

…nts added

…hort version simplified

…hildren - needed only in branch init

…ng assignments and constraints for branch / extension node)

…n_parent.rs

…node.rs

…ed into leaf_value.rs

…er files

…missing constraint added

…nd to boolean proof selectors

…ting storage proof)

…as added)

Some refactoring which I believe decreases code duplication and increases code readability. Some TODOs: - [x] The code required to get the previous rlc/mult data or the inclusion in the parent check is quite complicated because of the different node types. Instead it may be better to use a fixed location to store this data in so a node can simply use this data directly instead of having to figure out on its own where to find the data. This is cleaner because this way each node can decide on its own how these should be handled. - [x] Currently RLP decoding is done using a couple of selectors that are inputs from the prover. Then there are some checks if these are correct, though these are not complete. I think it's easier to think about this if we would just use a lookup to directly verify if these selectors are set correctly so we don't have to worry about edge cases are cases that are hard to constrain using custom gates. - [x] There are currently many cases in the main state maching because each row type is it's own state. However there is not really any reuse between custom gates between these rows, except for branches. It'll likely be quite a bit simple to just have a single state for account, storage and extension and just use multiple rows in those states - [x] May be a good idea to split up branches and extension nodes. (semi done) - [ ] There's a couple of circuit tools that were added in this PR to make writing the MPT circuit more manageable. A lot of these tools can still be greatly improved. - [ ] Number of lookups has been reduced a lot, but there are still many optimization possibilities (have not looked into reducing the expression degree for example). - [x] The circuit uses a fixed layout which uses around 100 columns (of which a lot need to be byte constrained so needs a lot of lookups as well). This makes the circuit quite a bit more dense than probably required, a more flexible way to manager the required data so the width/height can be choses would be very useful I think.

# Conflicts: # Cargo.lock # gadgets/src/util.rs # zkevm-circuits/Cargo.toml # zkevm-circuits/src/bytecode_circuit/dev.rs # zkevm-circuits/src/evm_circuit.rs # zkevm-circuits/src/evm_circuit/step.rs # zkevm-circuits/src/evm_circuit/util.rs # zkevm-circuits/src/keccak_circuit/keccak_packed_multi.rs # zkevm-circuits/src/lib.rs # zkevm-circuits/src/table.rs # zkevm-circuits/src/tx_circuit.rs # zkevm-circuits/src/util.rs # zkevm-circuits/src/witness/mpt.rs

…ookupTable

…or some opcodes (privacy-scaling-explorations#1415) ### Description Reference go-ethereum function [calcMemSize64WithUint](https://github.com/ethereum/go-ethereum/blob/84c3799e21d61d677965715fe09f8209660b4009/core/vm/common.go#L38), ignore to check Uint64 overflow for memory offset if length is zero. it is also called by [calcMemSize64](https://github.com/ethereum/go-ethereum/blob/84c3799e21d61d677965715fe09f8209660b4009/core/vm/common.go#LL31C9-L31C30). And both are used for opcodes in [memory_table.go](https://github.com/ethereum/go-ethereum/blob/84c3799e21d61d677965715fe09f8209660b4009/core/vm/memory_table.go#L20) as `memorySize` in [jump_table.go](https://github.com/ethereum/go-ethereum/blob/84c3799e21d61d677965715fe09f8209660b4009/core/vm/jump_table.go#L387). For Call opcodes, in offset and size are truncated to Uint64 as [opCall](https://github.com/ethereum/go-ethereum/blob/84c3799e21d61d677965715fe09f8209660b4009/core/vm/instructions.go#LL672C60-L672C60). ### Issue Link Related issue privacy-scaling-explorations#1301 Original local PR scroll-tech#393 ### Type of change - [X] Bug fix (non-breaking change which fixes an issue) ### How Has This Been Tested? 1. Fix `testool` case `randomStatetest85_d0_g0_v0`. 2. Add test cases of overflow offset and zero length for related opcodes.

### Description We treat empty accounts by storing their code_hash in the RwTable as 0. EXTCODECOPY was obtaining the bytecode length by querying the bytecode table with code_hash=0 on existing accounts, but that entry should be invalid (there's no bytecode with code_hash=0). Skip the bytecode table length lookup when code_hash=0. I've also reintroduced the `Block::debug_print_txs_steps_rw_ops` function, updated to use the new `Block::get_rws` API. This function is not used in the code, but it's very convenient to call it when debugging. ### Issue Link Resolve privacy-scaling-explorations#1190 ### Type of change - [x] Bug fix (non-breaking change which fixes an issue)

…ng-explorations#1419) ### Description NOTE: This is an updated version of privacy-scaling-explorations#1356 This is Part A of a 3 part pull request to add support for `CREATE`/`CREATE2` opcodes. Part A: privacy-scaling-explorations#1356 Part B: privacy-scaling-explorations#1357 Part C: privacy-scaling-explorations#1358 ### Issue Link privacy-scaling-explorations#1130 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents As part of the bigger additions needed for the `CREATE`/`CREATE2` opcodes' gadget, this PR adds support for the copy circuit to "always" have a value accumulator field `value_acc`. ### Rationale We need a value accumulator (of the random linear combination) in order to get the `RLC(bytes)` for the bytes copied from `Memory` to `Bytecode` (specifically the init code). This RLC is later used to do a lookup to the Keccak table to check the value of `keccak256(init_code)`. ### How Has This Been Tested? The existing tests for copy circuit pass for the updated constraints on the copy circuit. --------- Co-authored-by: Rohit Narurkar <[email protected]> Co-authored-by: KimiWu <[email protected]>

…adgets (privacy-scaling-explorations#1425) ### Description **NOTE: This is an updated version of privacy-scaling-explorations#1357 This PR is actually based on top of privacy-scaling-explorations#1419 ### Issue Link privacy-scaling-explorations#1130 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents Error types for insufficient balance and nonce overflow. These are supporting changes required for the CREATE/CREATE2 opcodes' gadget. ### Rationale The above errors will be handled within the CREATE/CREATE2 opcodes' gadget. In case of insufficient balance, it is also handled in the CallOp gadget for call related opcodes. --------- Co-authored-by: Rohit Narurkar <[email protected]>

### Description The release drafter was used to create a list of changes in the release note. As Github now provides this functionality by native, there's no need to maintain this CI script. ### Issue Link [_link issue here_] ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update

…-scaling-explorations#1440) ### Description - We remove the keccak256 crate. - We migrate the keccak256 plain implementation to the eth-types crate. As we migrate keccak circuit to the zkevm-crate, most of the functions left in keccak256 crate are unused except of the plain keccak hash implementation. Most of the crates in the codebase depend on keccak256 crate because they use the plain keccak hash. The plain keccak hash is only 300 lines big. It would be beneficial to keep a plain implementation for people to audit the optimized keccak circuit. ### Type of change Bug fix (non-breaking change which fixes an issue)

### Description This PR simply merges the current `main` into the MPT branch `mpt2`. This is the first step to get some further MPT changes merged into the MPT branch without making the PRs too big. ``` This PR contains: - Merge `main` into `mpt2` with the necessary changes to the MPT circuit ``` ### Issue Link [_link issue here_] ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - [_item_] ### Rationale [_design decisions and extended information_] ### How Has This Been Tested? Intermediate step, so limited testing --------- Signed-off-by: smtmfft <[email protected]> Signed-off-by: smtmfft <[email protected]> Co-authored-by: pinkiebell <[email protected]> Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: z2trillion <[email protected]> Co-authored-by: Eduard S <[email protected]> Co-authored-by: adria0.eth <[email protected]> Co-authored-by: Han <[email protected]> Co-authored-by: smtmfft <[email protected]> Co-authored-by: smtmfft <[email protected]> Co-authored-by: Chih Cheng Liang <[email protected]> Co-authored-by: DreamWuGit <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]> Co-authored-by: Zhang Zhuo <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: Wu Sung Ming <[email protected]> Co-authored-by: xiaodino <[email protected]> Co-authored-by: Mason Liang <[email protected]> Co-authored-by: Steven <[email protected]> Co-authored-by: Carlos Pérez <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: AronisAt79 <[email protected]> Co-authored-by: Mason Liang <[email protected]> Co-authored-by: JohnWick2ETH <[email protected]> Co-authored-by: kunxian xia <[email protected]> Co-authored-by: Leo Lara <[email protected]> Co-authored-by: zengzengzenghuy <[email protected]> Co-authored-by: john xu <[email protected]> Co-authored-by: Miha Stopar <[email protected]> Co-authored-by: aguzmant103 <[email protected]> Co-authored-by: Richord <[email protected]> Co-authored-by: Kimi Wu <[email protected]> Co-authored-by: Mickey <[email protected]> Co-authored-by: Luozhu <[email protected]> Co-authored-by: DoHoon Kim <[email protected]> Co-authored-by: jeong0982 <[email protected]> Co-authored-by: Andy Arditi <[email protected]> Co-authored-by: David Nevado <[email protected]> Co-authored-by: omahs <[email protected]> Co-authored-by: Richord <[email protected]> Co-authored-by: ntampakas <[email protected]> Co-authored-by: ashWhiteHat <[email protected]> Co-authored-by: naure <[email protected]> Co-authored-by: Aurélien Nicolas <[email protected]> Co-authored-by: testuser-at-490752553772 <[email protected]> Co-authored-by: xiaodino <[email protected]> Co-authored-by: Thomas Pan <[email protected]> Co-authored-by: Akase Cho <[email protected]> Co-authored-by: Vu <[email protected]> Co-authored-by: Alex Beregszaszi <[email protected]> Co-authored-by: Enrico Bottazzi <[email protected]> Co-authored-by: adria0 <adria0@nowhere>

…orations#1448) ### Description This is a very small MRs removing some overhead. It replaces the types/structures for Gas, GasCost and ProgramCounter by u64. ### Issue Link Issue privacy-scaling-explorations#1404 ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents ### Rationale Keeping the existing code but removing the structures. ### How Has This Been Tested? No tests were added. --------- Co-authored-by: adria0.eth <[email protected]>

### Description This is a very small PR. While investigating privacy-scaling-explorations#1439 I noticed we don't have an integration test for the Public Inputs Circuit, so I just added it. ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update

…es (privacy-scaling-explorations#1424) ### Description 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). ### Issue Link Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 ### Type of change - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### How Has This Been Tested? Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <[email protected]>

### Description In the RLC gadget, the indicator `is_lt_128` must be equivalent to `value < 128`. However, currently only the `true` case is handled. This PR handles both `true` and `false` cases. ### Issue Link Scroll internal. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) --------- Co-authored-by: Aurélien Nicolas <[email protected]> Co-authored-by: Han <[email protected]>

# Conflicts: # Cargo.lock # circuit-benchmarks/Cargo.toml # eth-types/src/geth_types.rs # gadgets/src/util.rs # keccak256/Cargo.toml # keccak256/src/arith_helpers.rs # keccak256/src/keccak_arith.rs # keccak256/src/lib.rs # keccak256/src/plain.rs # testool/src/compiler.rs # zkevm-circuits/Cargo.toml # zkevm-circuits/src/evm_circuit.rs # zkevm-circuits/src/pi_circuit.rs # zkevm-circuits/src/state_circuit.rs # zkevm-circuits/src/state_circuit/constraint_builder.rs # zkevm-circuits/src/table.rs # zkevm-circuits/src/table/keccak_table.rs # zkevm-circuits/src/table/mpt_table.rs # zkevm-circuits/src/tx_circuit/dev.rs # zkevm-circuits/src/tx_circuit/sign_verify.rs # zkevm-circuits/src/util.rs # zkevm-circuits/src/witness/mpt.rs

# Conflicts: # Cargo.lock # gadgets/src/util.rs # rust-toolchain # zkevm-circuits/Cargo.toml # zkevm-circuits/src/bytecode_circuit/circuit.rs # zkevm-circuits/src/bytecode_circuit/dev.rs # zkevm-circuits/src/circuit_tools/gadgets.rs # zkevm-circuits/src/evm_circuit.rs # zkevm-circuits/src/evm_circuit/step.rs # zkevm-circuits/src/evm_circuit/util.rs # zkevm-circuits/src/evm_circuit/util/instrumentation.rs # zkevm-circuits/src/keccak_circuit/cell_manager.rs # zkevm-circuits/src/lib.rs # zkevm-circuits/src/mpt_circuit.rs # zkevm-circuits/src/mpt_circuit/account_leaf.rs # zkevm-circuits/src/mpt_circuit/branch.rs # zkevm-circuits/src/mpt_circuit/extension.rs # zkevm-circuits/src/mpt_circuit/helpers.rs # zkevm-circuits/src/mpt_circuit/rlp_gadgets.rs # zkevm-circuits/src/mpt_circuit/start.rs # zkevm-circuits/src/mpt_circuit/storage_leaf.rs # zkevm-circuits/src/table.rs # zkevm-circuits/src/tx_circuit.rs

condition excluded, would be better if optimize condition as well

Challenge api

Commits on Apr 26, 2023

Add back keccak endianess option

Brechtpd committed Apr 26, 2023

Configuration menu

View commit details

Copy full SHA for 31a0b83

Browse repository at this point

Copy the full SHA

31a0b83 View commit details

Browse the repository at this point in the history

Commits on May 4, 2023

updates, still needs to fix CM

CeciliaZ030 committed May 4, 2023

Configuration menu

View commit details

Copy full SHA for a04940c

Browse repository at this point

Copy the full SHA

a04940c View commit details

Browse the repository at this point in the history

Commits on May 9, 2023

circuit tools & test:

CeciliaZ030 committed May 9, 2023

Configuration menu

View commit details

Copy full SHA for 4ee4a27

Browse repository at this point

Copy the full SHA

4ee4a27 View commit details

Browse the repository at this point in the history

Commits on May 11, 2023

trait ChallengeSet

CeciliaZ030 committed May 11, 2023

Configuration menu

View commit details

Copy full SHA for 32d81d9

Browse repository at this point

Copy the full SHA

32d81d9 View commit details

Browse the repository at this point in the history

Commits on May 19, 2023

updates

CeciliaZ030 committed May 19, 2023

Configuration menu

View commit details

Copy full SHA for 244fe70

Browse repository at this point

Copy the full SHA

244fe70 View commit details

Browse the repository at this point in the history

Commits on May 30, 2023

CachedRegion init & descrption

CeciliaZ030 committed May 30, 2023

Configuration menu

View commit details

Copy full SHA for 7bfe635

Browse repository at this point

Copy the full SHA

7bfe635 View commit details

Browse the repository at this point in the history

Commits on Jun 6, 2023

more cleanup

Brechtpd committed Jun 6, 2023

Configuration menu

View commit details

Copy full SHA for 8ec4362

Browse repository at this point

Copy the full SHA

8ec4362 View commit details

Browse the repository at this point in the history

Commits on Jun 8, 2023

some more cleanup

Brechtpd committed Jun 8, 2023

Configuration menu

View commit details

Copy full SHA for 6dad45a

Browse repository at this point

Copy the full SHA

6dad45a View commit details

Browse the repository at this point in the history

Commits on Jun 16, 2023

Working keccak input endianess change

Brechtpd committed Jun 16, 2023

Configuration menu

View commit details

Copy full SHA for 4abbbe5

Browse repository at this point

Copy the full SHA

4abbbe5 View commit details

Browse the repository at this point in the history

Commits on Jun 26, 2023

Enable keccak input challenge

Brechtpd committed Jun 26, 2023

Configuration menu

View commit details

Copy full SHA for 7e141c4

Browse repository at this point

Copy the full SHA

7e141c4 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Circuit tools #123

Circuit tools #123

Commits on Oct 27, 2022

Commits on Oct 28, 2022

Commits on Apr 5, 2023

Commits on Apr 8, 2023

Commits on Apr 26, 2023

Commits on Apr 28, 2023

Commits on May 3, 2023

Commits on May 4, 2023

Commits on May 5, 2023

Commits on May 6, 2023

Commits on May 9, 2023

Commits on May 11, 2023

Commits on May 12, 2023

Commits on May 19, 2023

Commits on May 20, 2023

Commits on May 23, 2023

Commits on May 25, 2023

Commits on May 26, 2023

Commits on May 29, 2023

Commits on May 30, 2023

Commits on May 31, 2023

Commits on Jun 1, 2023

Commits on Jun 2, 2023

Commits on Jun 3, 2023

Commits on Jun 4, 2023

Commits on Jun 5, 2023

Commits on Jun 6, 2023

Commits on Jun 7, 2023

Commits on Jun 8, 2023

Commits on Jun 16, 2023

Commits on Jun 17, 2023

Commits on Jun 18, 2023

Commits on Jun 26, 2023

Commits on Jun 28, 2023

Commits on Jun 29, 2023