This repository has been archived by the owner on May 3, 2024. It is now read-only.
forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 125
Add integration tests to allow loading in Taiko blocks into the circuit #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaodino
changed the title
Xiaodino/loading taiko
Allow loading in Taiko blocks into the circuit
Jun 26, 2023
xiaodino
changed the title
Allow loading in Taiko blocks into the circuit
Add integration tests to allow loading in Taiko blocks into the circuit
Jun 26, 2023
smtmfft
reviewed
Jun 29, 2023
johntaiko
reviewed
Jun 30, 2023
smtmfft
approved these changes
Jun 30, 2023
Brechtpd
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool. :)
I think next steps would be:
- Connect to the actual Taiko circuits
- Make the tests pass (looks like there is some invalid signature problem, maybe related to the chain id or something)
- Local data generation:
-Allow generating the data locally using a Taiko node like currently is possible from a standard geth node.- Modify that test data generation to include the anchor transaction (maybe a simplified dummy anchor function because otherwise the circuits already seem to have to be quite big).
Brechtpd
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but let's first do the next steps written in my comment above before merging this one in the master. Or at least the part of connecting with the Taiko super circuit and making sure the tests don't fail. The offchain test generation using a Taiko node can be done afterwards if that makes things simpler.
smtmfft
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a convenient method for testing circuits against actual Taiko block data. It doesn't need to run a node software.
It incorporates the ability to load Taiko block data through the URL "https://rpc.internal.taiko.xyz/." To set this URL, use the command export
GETH0_URL="https://rpc.internal.taiko.xyz"
The integration tests included in this PR cover the following circuit:
and the following example blocks:
Issue Link
#108
Type of change
Contents
This PR includes two integration tests:
taiko_circuit_input_builder.rs
: Tests the circuit input builder.taiko_circuits.rs
: Tests the circuit prover.The PR is not to address the circuit prover failures such as invalid signature.
How Has This Been Tested?
Block explorer URL is https://explorer.internal.taiko.xyz