This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat: add anchor transaction circuit #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johntaiko
commented
Jun 1, 2023
Brechtpd
reviewed
Jun 10, 2023
johntaiko
force-pushed
the
feat/anchor_tx
branch
3 times, most recently
from
3e47d2e
to
dfa9da6
Compare
|
Haven't looked into all the changes in detail, but the changes look very good! Will look more closely tomorrow. |
johntaiko
force-pushed
the
feat/anchor_tx
branch
from
dfa9da6
to
08f3d46
Compare
ggkitsas
reviewed
Jun 20, 2023
Brechtpd
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Looks great!
I think one thing that is missing is byte lookups to ensure that all bytes are in the [0,255] range? Both in the anchor circuit and the sign_verify circuit.
Created a PR with some other misc changes to mainly add some extra comments: #116
johntaiko
force-pushed
the
feat/anchor_tx
branch
3 times, most recently
from
e960000
to
3622cbd
Compare
johntaiko
force-pushed
the
feat/anchor_tx
branch
from
3622cbd
to
385f06c
Compare
Brechtpd
reviewed
Jun 22, 2023
| ); | ||
|
|
||
| // Range constraint all bytes | ||
| meta.lookup_any("ensure all bytes are actually byte values", |meta| { |
There was a problem hiding this comment.
Just simplified this one so the lookup is always done. This is fine because the column is always used to store just byte values, or is not used in which case it just stores 0.
Brechtpd
approved these changes
Jun 22, 2023
ggkitsas
approved these changes
Jun 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/taikoxyz/Anchor-Circuit-code-review-helper-33d8cf27522443d7b05251c2c72ea991?pvs=4