fix(taiko-client): make sure the length of txLists is not bigger than the maxBlocksPerBatch. #18855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mask-pp
changed the title
| if err := p.ProposeTxListPacaya(ctx, txLists); err != nil { | ||
| return err | ||
| // Make sure the tx list is not bigger than the maxBlocksPerBatch. | ||
| maxBlocksPerBatch, _ := p.protocolConfigs.MaxBlocksPerBatch() |
There was a problem hiding this comment.
Let's check the error here, or u don't need to make this function return an error.
There was a problem hiding this comment.
Don't need to return error, and removed.
| maxBlocksPerBatch, _ := p.protocolConfigs.MaxBlocksPerBatch() | ||
| for ; len(txLists) > 0; txLists = txLists[min(maxBlocksPerBatch, len(txLists)):] { | ||
| // If the current L2 chain is after ontake fork, batch propose all L2 transactions lists. | ||
| if err := p.ProposeTxListPacaya(ctx, txLists[:min(maxBlocksPerBatch, len(txLists))]); err != nil { |
There was a problem hiding this comment.
We need to pass the whole txLists to ProposeTxListPacaya, let's check the count inside ProposeTxListPacaya.
There was a problem hiding this comment.
Added check inside the ProposeTxListPacaya .
davidtaikocha
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.