feat(all): preconfs #281

cyberhorsey · 2024-06-27T01:54:27Z

No description provided.

mask-pp · 2024-06-27T02:23:27Z

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

internal/ethapi/api.go

cyberhorsey · 2024-06-27T02:31:31Z

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

internal/ethapi/preconf.go

mask-pp · 2024-06-27T02:40:23Z

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed.

YoGhurt111 · 2024-06-27T03:33:49Z

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed.

I agree to use a new API.
This will avoid breaking the interface in some libs depending on eth's native SendTransaction.

cyberhorsey · 2024-06-27T15:46:57Z

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed.

I agree to use a new API. This will avoid breaking the interface in some libs depending on eth's native SendTransaction.

The team building the preconfs wants to use the same API for the testnet.

davidtaikocha · 2024-06-30T07:57:05Z

Lets keep these changes in another branch instead of taiko branch.

…onfs

mask-pp · 2024-08-23T03:06:26Z

eth/ethconfig/config.go

@@ -160,6 +160,9 @@ type Config struct {

 	// OverrideVerkle (TODO: remove after the fork)
 	OverrideVerkle *uint64 `toml:",omitempty"`
+
+	// change(taiko): preconf url


Suggested change

// change(taiko): preconf url

// CHANGE(taiko): preconf url

mask-pp · 2024-08-23T03:06:43Z

eth/backend.go

@@ -252,7 +255,8 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) {
 	eth.miner = miner.New(eth, &config.Miner, eth.blockchain.Config(), eth.EventMux(), eth.engine, eth.isLocalBlock)
 	eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData))

-	eth.APIBackend = &EthAPIBackend{stack.Config().ExtRPCEnabled(), stack.Config().AllowUnprotectedTxs, eth, nil}
+	// change(TAIKO): preconfirmation URL


Suggested change

// change(TAIKO): preconfirmation URL

// CHANGE(taiko): preconfirmation URL

mask-pp · 2024-08-23T03:06:52Z

eth/backend.go

@@ -101,6 +101,9 @@ type Ethereum struct {
 	lock sync.RWMutex // Protects the variadic fields (e.g. gas price and etherbase)

 	shutdownTracker *shutdowncheck.ShutdownTracker // Tracks if and when the node has shutdown ungracefully
+
+	// change(taiko)


mask-pp · 2024-08-23T03:07:27Z

accounts/abi/bind/base.go

@@ -423,6 +423,7 @@ func (c *BoundContract) transact(opts *TransactOpts, contract *common.Address, i
 	if opts.NoSend {
 		return signedTx, nil
 	}
+	// change(taiko): slot and sig


mask-pp · 2024-08-23T03:09:06Z

cmd/geth/main.go

@@ -180,6 +180,7 @@ var (
 		utils.AllowUnprotectedTxs,
 		utils.BatchRequestLimit,
 		utils.BatchResponseMaxSize,
+		utils.PreconfirmationForwardingURLFlag,


Suggested change

utils.PreconfirmationForwardingURLFlag,

utils.PreconfirmationForwardingURL,

run.sh

mask-pp · 2024-08-23T03:12:34Z

Unless it is a version upgradation, please do not add extra logs or blank lines in unmodified areas.

mask-pp · 2024-08-23T03:13:40Z

internal/ethapi/api.go

-	if err != nil {
-		return nil, NewTxIndexingError() // transaction is not fully indexed
+	if err != nil || !found {
+		// change(taiko): check to see if it exists from the preconfer.


mask-pp · 2024-08-23T03:18:24Z

Please use the unique CHANGE(taiko): tag when making any modifications.

cyberhorsey · 2024-08-23T04:10:08Z

Please use the unique CHANGE(taiko): tag when making any modifications.

yep, when this PR is ready for review I'll tag you, it's just constant crap rn because I push changes to log and test stuff.

…onfs

davidtaikocha · 2024-11-05T07:31:35Z

Closed by 266c8ca

* feat(beacon): introduce soft blocks * feat: update api.go * chore(ci): update CI * feat: update L1Origin * feat: update `verifyHeader` * test: update tests * feat: update consensus * feat: update consensus * feat: update genesis * feat: remove timestamp check in prepareWork * feat: merge changes in #281 * Update eth/catalyst/api.go Co-authored-by: maskpp <[email protected]> * Update internal/ethapi/taiko_preconf.go Co-authored-by: maskpp <[email protected]> * fix consensus test * revert commit f1df58 * fix consensus test (#349) * Update eth/catalyst/api.go Co-authored-by: maskpp <[email protected]> * feat: add back timestamp check in worker * add genesis * temp fix for old l1origin * nil value * feat: rename to `L1OriginLegacy` * feat: change `common.Big0` as the default value for legacy l1Origin, to make `IsSoftblock` return `false` * feat(beacon): change the reorg log level (#350) * use debug log level to avoid logging too many logs when frequently soft block reorg. * use debug log level to avoid logging too many logs when frequently soft block reorg. * feat: check --taiko flag --------- Co-authored-by: David <[email protected]> * add rlp optional flag (#353) * fix lint * fix test case * feat(l1Origin): remove the reverted l1Origins (#355) * remove the reverted l1Origins * feat: add more comments --------- Co-authored-by: David <[email protected]> * only forward txs * chore: update ci --------- Co-authored-by: maskpp <[email protected]> Co-authored-by: Jeffery Walsh <[email protected]>

basisc slot/signature preconfs addition

c8648e9

cyberhorsey changed the base branch from master to taiko June 27, 2024 01:54

cyberhorsey requested review from davidtaikocha, mask-pp, Brechtpd and YoGhurt111 June 27, 2024 02:07

mask-pp reviewed Jun 27, 2024

View reviewed changes

internal/ethapi/api.go Outdated Show resolved Hide resolved

mask-pp reviewed Jun 27, 2024

View reviewed changes

internal/ethapi/preconf.go Outdated Show resolved Hide resolved

cyberhorsey added 3 commits June 27, 2024 18:16

Remove slog and signature, also hijack eth_getTransactionReceipt

5c474c0

.

ed57045

encode

9e91c83

YoGhurt111 approved these changes Jun 30, 2024

View reviewed changes

cyberhorsey and others added 12 commits July 2, 2024 11:56

preconfs nework support

e4147eb

build on pr

9316c67

.'

3e33107

change image url

962c01a

Merge branch 'taiko' into preconfs

d4ae804

spew

283c866

Merge branch 'preconfs' of github.com:taikochain/taiko-geth into prec…

07d9ac7

…onfs

log

8175e6d

oops

0be6e70

forward addtl calls

c09982c

lint

11547c6

Merge branch 'taiko' into preconfs

86dc5a9

cyberhorsey and others added 13 commits July 26, 2024 11:20

forwarding

7391e27

.

4ccf51d

Log

d1ab2fb

Check local before forwarding

bf451ad

Merge branch 'taiko' into preconfs

b96e4b7

update genesis for helder

6674bcf

Merge branch 'preconfs' of github.com:taikochain/taiko-geth into prec…

cd7ecf3

…onfs

ontake block

b46389f

Merge branch 'taiko' into preconfs

9a8241c

log

c579ad7

log

6f0827b

moar logs

c6597c6

genesis

a2e96fd

mask-pp reviewed Aug 23, 2024

View reviewed changes

cyberhorsey and others added 5 commits September 10, 2024 09:10

Merge branch 'taiko' into preconfs

7510e3c

Merge branch 'taiko' into preconfs

649a1e5

genesis

dc64cdf

Merge branch 'preconfs' of github.com:taikochain/taiko-geth into prec…

34d90f5

…onfs

genesis

66e3912

davidtaikocha added the option.do-not-merge label Sep 24, 2024

cyberhorsey added 2 commits October 7, 2024 18:06

merge taiko branch in

4f349c3

return err

47b52e4

davidtaikocha added a commit that referenced this pull request Nov 5, 2024

feat: merge changes in #281

266c8ca

davidtaikocha closed this Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(all): preconfs #281

feat(all): preconfs #281

cyberhorsey commented Jun 27, 2024 •

edited

Loading

mask-pp commented Jun 27, 2024

cyberhorsey commented Jun 27, 2024

mask-pp commented Jun 27, 2024

YoGhurt111 commented Jun 27, 2024

cyberhorsey commented Jun 27, 2024

davidtaikocha commented Jun 30, 2024

mask-pp Aug 23, 2024

mask-pp Aug 23, 2024

mask-pp Aug 23, 2024

mask-pp Aug 23, 2024

mask-pp Aug 23, 2024

mask-pp commented Aug 23, 2024 •

edited

Loading

mask-pp Aug 23, 2024

mask-pp commented Aug 23, 2024

cyberhorsey commented Aug 23, 2024

davidtaikocha commented Nov 5, 2024

	// change(TAIKO): preconfirmation URL
	// CHANGE(taiko): preconfirmation URL

	utils.PreconfirmationForwardingURLFlag,
	utils.PreconfirmationForwardingURL,

feat(all): preconfs #281

feat(all): preconfs #281

Conversation

cyberhorsey commented Jun 27, 2024 • edited Loading

mask-pp commented Jun 27, 2024

cyberhorsey commented Jun 27, 2024

mask-pp commented Jun 27, 2024

YoGhurt111 commented Jun 27, 2024

cyberhorsey commented Jun 27, 2024

davidtaikocha commented Jun 30, 2024

mask-pp Aug 23, 2024

Choose a reason for hiding this comment

mask-pp Aug 23, 2024

Choose a reason for hiding this comment

mask-pp Aug 23, 2024

Choose a reason for hiding this comment

mask-pp Aug 23, 2024

Choose a reason for hiding this comment

mask-pp Aug 23, 2024

Choose a reason for hiding this comment

mask-pp commented Aug 23, 2024 • edited Loading

mask-pp Aug 23, 2024

Choose a reason for hiding this comment

mask-pp commented Aug 23, 2024

cyberhorsey commented Aug 23, 2024

davidtaikocha commented Nov 5, 2024

cyberhorsey commented Jun 27, 2024 •

edited

Loading

mask-pp commented Aug 23, 2024 •

edited

Loading