Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Risc-V toolchain): don't hardcode absolute path in /opt #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Jun 26, 2024

The installation path of riscv32-unknown-elf-gcc is distro-specific. For example in mine it's in the standard /usr/bin, instead of non-standard /opt/riscv/bin/

image

The standard way to make binary available regardless of physical location (local, opt, /usr/bin) is to add them to $PATH, which I assume any installer is doing.

@CeciliaZ030
Copy link
Contributor

you also gotta change here

mkdir /opt/riscv

if you want to make it distro-specific :)

@mratsim
Copy link
Contributor Author

mratsim commented Jun 28, 2024

For now this PR is paused, I think we need to review the install script maybe we need one for users and one for Github Actions. The current one assumes Docker and root permissions.

See #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants