Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): change GuestOutput and the zk committed value for onchain verification #282

Merged
merged 10 commits into from
Jun 9, 2024

Conversation

CeciliaZ030
Copy link
Contributor

The zk provers should return the ProtocolInput hash to match the onchain verifier, when it fails to generate pi_hash the proof should just fail and ZkVM should exit. In that case, the GuestOutput::Failure will never be used and currently it's not used reasonably so we should just remove the case.

pub enum GuestOutput {
    Success {
        header: AlloyConsensusHeader,
        hash: B256,
    },
    Failure,
}

change to:

pub enum GuestOutput {
    header: AlloyConsensusHeader,
    hash: B256,
}

For verifier support, see taikoxyz/taiko-mono#17215

@CeciliaZ030 CeciliaZ030 changed the title feat(prover): change GuestOutput and the zk committed value for onchain verification feat(prover): change GuestOutput and the zk committed value for onchain verification Jun 9, 2024
@CeciliaZ030 CeciliaZ030 requested a review from Brechtpd June 9, 2024 01:08
@CeciliaZ030 CeciliaZ030 added this pull request to the merge queue Jun 9, 2024
Merged via the queue into main with commit 37f6c49 Jun 9, 2024
14 of 15 checks passed
@CeciliaZ030 CeciliaZ030 deleted the guest-returns-ProtocalInstance branch June 9, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants