Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable i18n lint #9450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: enable i18n lint #9450

wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

No description provided.

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 11, 2024 •
edited
Loading

Tests completed successfully ✅

Good job 🔥

@splincode splincode changed the title chore: enable i18n lint [WIP] chore: enable i18n lint Oct 11, 2024
@splincode splincode marked this pull request as draft October 11, 2024 11:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 986f537):

https://taiga-previews--pr9450-splincode-some-chang-v2lp0jrl.web.app

(expires Sun, 13 Oct 2024 10:11:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 11, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 294.88KB +10%
✅ demo/browser/vendor.(hash).js
 250.11KB +10%
✅ demo/browser/runtime.(hash).js
 43.07KB +10%
✅ demo/browser/styles.(hash).css
 16.27KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +3B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.1MB (+35B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

splincode
splincode commented Oct 12, 2024
View reviewed changes
projects/demo/src/modules/pipes/field-error/examples/5/index.ts
@@ -42,6 +42,7 @@ export default class Example {

constructor() {
this.form = this.fb.group({
// eslint-disable-next-line i18n/no-russian-character
text: ['русский текст', Validators.required],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@splincode splincode changed the title [WIP] chore: enable i18n lint chore: enable i18n lint Oct 12, 2024
@splincode splincode marked this pull request as ready for review October 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@splincode splincode

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@splincode