feat(core): migrate to longtap event #9444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillerSvt
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
mdlufy
as code owners
Tests completed successfully ✅Good job 🔥 |
|
Visit the preview URL for this PR (updated for commit b0c6cac): https://taiga-previews--pr9444-switch-to-longtap-ev-6ztg8fot.web.app (expires Sat, 12 Oct 2024 05:00:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +369B +0.06% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
splincode
approved these changes
Oct 11, 2024
| '(document:pointerdown.silent)': 'closeDropdown($event)', | ||
| '(document:contextmenu.capture.silent)': 'closeDropdown($event)', | ||
| '(document:keydown.esc)': 'closeDropdown()', | ||
| '(contextmenu.prevent.stop)': 'onContextMenu($event.clientX, $event.clientY)', | ||
| // cspell:disable-next-line |
There was a problem hiding this comment.
let's add longtap to ignore list and remove comment
https://github.com/taiga-family/taiga-ui/blob/main/.cspell.json
There was a problem hiding this comment.
There was a problem hiding this comment.
just remove cspell-disable-next-line comment then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #