Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo-playwright): move tests for legacy components to legacy #9245

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore(demo-playwright): move tests for legacy components to legacy #9245

merged 1 commit into from
Oct 10, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 27, 2024

Fixes #

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 27, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 29e10e1):

https://taiga-previews--pr9245-mdlufy-tests-xwowxqkq.web.app

(expires Fri, 11 Oct 2024 09:52:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 27, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 295KB +10%
✅ demo/browser/vendor.(hash).js
 247.33KB +10%
✅ demo/browser/runtime.(hash).js
 43.07KB +10%
✅ demo/browser/styles.(hash).css
 16.27KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.13MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode enabled auto-merge (squash) September 30, 2024 08:59
@mdlufy mdlufy marked this pull request as draft September 30, 2024 12:36
@mdlufy mdlufy changed the title chore(demo-playwright): move tests for legacy components to legacy [WIP] chore(demo-playwright): move tests for legacy components to legacy Sep 30, 2024
@mdlufy mdlufy force-pushed the mdlufy/tests branch 2 times, most recently from 98142d6 to 8f9577e Compare October 10, 2024 09:36
@mdlufy mdlufy marked this pull request as ready for review October 10, 2024 10:02
@mdlufy mdlufy changed the title [WIP] chore(demo-playwright): move tests for legacy components to legacy chore(demo-playwright): move tests for legacy components to legacy Oct 10, 2024
@mdlufy mdlufy merged commit ba27f7b into main Oct 10, 2024
25 checks passed
@mdlufy mdlufy deleted the mdlufy/tests branch October 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

Assignees

@mdlufy mdlufy

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdlufy @waterplea @splincode