Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): MultiSelect empty line when non empty placeholder and valueContent #9123

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 20, 2024

Close #9112

@github-actions github-actions bot added the v4 4.0 candidate label Sep 20, 2024
Copy link

lumberjack-bot bot commented Sep 20, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Visit the preview URL for this PR (updated for commit 73b71c6):

https://taiga-previews--pr9123-mdlufy-multi-select-p5hfkr9z.web.app

(expires Tue, 24 Sep 2024 08:26:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 20, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
42.32KB (-317B -0.73%) +10%
demo/browser/main.(hash).js
287.3KB (-540B -0.18%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.15KB +10%
demo/browser/styles.(hash).css
16.18KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change -857B -0.14%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.05MB (-73.1KB -1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy changed the title [WIP] fix(legacy): MultiSelect empty line when non empty placeholder and valueContent fix(legacy): MultiSelect empty line when non empty placeholder and valueContent Sep 23, 2024
@mdlufy mdlufy marked this pull request as ready for review September 23, 2024 07:29
@mdlufy mdlufy merged commit eda9293 into main Sep 23, 2024
26 of 27 checks passed
@mdlufy mdlufy deleted the mdlufy/multi-select branch September 23, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - MultiSelect. When inserting "placeholder", a blank line appears
3 participants