Merge pull request #11 from taga3s/refactor

update and refactor

Makefile

@@ -5,6 +5,10 @@ build:
 		@go build -o ./$(PROJECT_NAME) ./main.go
 		@echo "Build successful!"
 
+fmt:
+		@echo "Formatting the code..."
+		@go fmt ./...
+
 test:
 		@echo "Running tests..."
 		@go test -v ./...

internal/ascii_art/ascii_art.go

@@ -8,7 +8,7 @@ import (
 )
 
 const (
-	chars = "!\"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
+	validChars = "!\"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
 )
 
 func selectRandomly(chars string) string {
@@ -32,7 +32,7 @@ func Generate(dest image.Image, threshold int) string {
 			if gray.Y < uint8(threshold) {
 				line.WriteString(" ")
 			} else {
-				line.WriteString(selectRandomly(chars))
+				line.WriteString(selectRandomly(validChars))
 			}
 		}
 

main.go

@@ -24,15 +24,15 @@ func main() {
 			&cli.IntFlag{
 				Name:        "threshold",
 				Aliases:     []string{"t"},
-				Usage:       "threshold for ASCII art generation",
+				Usage:       "the threshold for ASCII Art Generation",
 				Value:       128,
 				Destination: &inputs.threshold,
 			},
 			&cli.Float64Flag{
 				Name:        "magnification",
 				Aliases:     []string{"m"},
-				Usage:       "magnification factor for ASCII art generation",
-				Value:       1,
+				Usage:       "the magnification factor for ASCII Art Generation",
+				Value:       1.0,
 				Destination: &inputs.magnification,
 			},
 		},
@@ -42,7 +42,7 @@ func main() {
 			}
 			inputs.path = c.Args().Get(0)
 
-			run(inputs)
+			run(&inputs)
 
 			return nil
 		},
@@ -53,7 +53,7 @@ func main() {
 	}
 }
 
-func run(inputs Inputs) {
+func run(inputs *Inputs) {
 	srcImg, err := img.Load(inputs.path)
 	if err != nil {
 		log.Fatalf("Error: %v", err)