Fix text in fixed seq #869
Open
+246
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
added
bug
serde
failures:
fixed_name::variable_size::text_and_value
variable_name::variable_size::text_and_value
Mingun
force-pushed
the
fix-text-in-fixed-seq
branch
from
6e6e10e to
86eeeea
Compare
failures:
serde-de-seq:
fixed_name::variable_size::text_and_value
variable_name::variable_size::text_and_value
serde-issues:
issue868
If sequence expected only tags, skip any texts (CDATA included)
If sequence expected any values, skip texts (CDATA included) if there is a dedicated "$text" field
Fixed:
serde-de-seq:
fixed_name::variable_size::text_and_value
variable_name::variable_size::text_and_value
serde-issues:
issue868
Mingun
force-pushed
the
fix-text-in-fixed-seq
branch
from
86eeeea to
aa23b65
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 60.74% 60.32% -0.43%
==========================================
Files 41 42 +1
Lines 16044 16578 +534
==========================================
+ Hits 9746 10000 +254
- Misses 6298 6578 +280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems:
$textand$valuespecial keys, text events should be mapped to the$textfieldFixes #868