Remove escape-html feature and the resolve_html5_entity function
#765
+19
−1,710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because since tafia#739 custom entity resolution function have precedence over standard one, so user can implement resolution of HTML entities by yourself.
|
We could remove it entirely, but I'd kind of prefer to keep it around but change the implementation to make it low-cost. We handle HTML attributes already, after all, there's no plans to remove that functionality |
|
Ok, I'll investigate this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because since #739 custom entity resolution function have precedence over standard one, user can implement resolution of HTML entities by yourself. So I think, we can completely remove HTML 5 support, which in any case was not ideal. Instead of use big
matchstatement it is probably better to useHashMapwith predefined entities and user can do that.