Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyper-boring's
HttpsConnector
requires theResponse
type to implementDebug
. SinceProxyStream
doesn't implementDebug
one cannot create aHttpsConnector<ProxyStream<HttpConnector>>
with Boring SSL. Compilation will fail with this errorIt's debatable whether the change should go here or in cloudflare/boring/hyper-boring. Hyper-boring is forked from hyper-openssl and while hyper-openssl did originally have that
Debug
requirement, they dropped it when they upgraded to hyper v0.14. Hyper-boring is also on v0.14 but didn't remove that requirement.I'm requesting the change be implemented here in hyper-proxy because it's a one line change that won't break anything, whereas it could be many lines and many possible breakages downstream if it was in hyper-boring.