-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support T
and T?
methods with the same name
#1758
Open
i582
wants to merge
11
commits into
main
Choose a base branch
from
pmakhnev/optional-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T
and T?
methods with the same name
@@ -353,7 +353,7 @@ export const MapFunctions: ReadonlyMap<string, AbiFunction> = new Map([ | |||
const [self] = args; | |||
checkMapType(self, ref); | |||
|
|||
return { kind: "ref", name: "Cell", optional: true }; | |||
return { kind: "ref", name: "Cell", optional: false }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, this wouldn't fail at runtime?
contract Foo {
get fun foo(): Slice {
let x: map<Int, Int> = emptyMap();
return x.asCell().asSlice();
}
}
Gusarich
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snippet below throws an internal compiler error.
extends fun foo(self: Int) {
return self * 2;
}
fun bar(x: Int?) {
x.foo();
}
[INTERNAL COMPILER ERROR]: Type Int_optional not found
Please report at https://github.com/tact-lang/tact/issues
96 | const msg = `[INTERNAL COMPILER ERROR]: ${message}\nPlease report at https://github.com/tact-lang/tact/issues`;
97 | throw source === undefined
> 98 | ? new TactInternalCompilerError(msg)
| ^
99 | : new TactInternalCompilerError(
100 | `${locationStr(source)}\n${msg}\n${source.interval.getLineAndColumnMessage()}`,
101 | source,
at throwInternalCompilerError (src/error/errors.ts:98:11)
at getType (src/types/resolveDescriptors.ts:2113:35)
at resolveCall (src/types/resolveExpression.ts:644:29)
at resolveExpression (src/types/resolveExpression.ts:947:20)
at processStatements (src/types/resolveStatements.ts:434:48)
at processFunctionBody (src/types/resolveStatements.ts:763:17)
at resolveStatements (src/types/resolveStatements.ts:803:19)
at Object.<anonymous> (src/types/resolveStatements.spec.ts:24:36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1285.
Checklist