Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check map types for deepEquals method #1718

Merged
merged 5 commits into from
Feb 5, 2025
Merged

fix: check map types for deepEquals method #1718

merged 5 commits into from
Feb 5, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 5, 2025 •
edited
Loading

Issue

Closes #1261.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Feb 5, 2025
@i582 i582 marked this pull request as ready for review February 5, 2025 16:16
@i582 i582 requested a review from a team as a code owner February 5, 2025 16:16
@anton-trunov anton-trunov merged commit ca634cd into main Feb 5, 2025
24 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/fix-deepEquals-typecheck branch February 5, 2025 18:00
@anton-trunov anton-trunov self-assigned this Feb 5, 2025
sansx pushed a commit to TownSquareXYZ/tact that referenced this pull request Feb 10, 2025
@i582 @sansx
fix: check map types for deepEquals method (tact-lang#1718)
d096a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

deepEquals does not always check arguments' types are the same
2 participants
@i582 @anton-trunov