Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update base colors #243

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat: update base colors #243

merged 1 commit into from
Nov 20, 2024

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Nov 1, 2024

  • We now export Spacing and Border Radius as objects again.
  • Switched to using asdf rather than nvm so we can use bun to run typescript files.
  • Did ad-hoc re-coloring of the Skeleton due to color changes and added a story for it to test

BREAKING CHANGE: All -—primary variables are now removed, if you needed the value for our logo use —-brand-static in all other cases use —-brand-primary which is a light/dark aware purple “primary” color.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@SimeonC SimeonC added the major Increment the major version when merged label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0

Results for commit 1bd81f0.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC force-pushed the update-variables branch 3 times, most recently from cd2b203 to 6f34aeb Compare November 5, 2024 07:10
wahidfarid
wahidfarid previously approved these changes Nov 6, 2024
SashaShostyr
SashaShostyr previously approved these changes Nov 6, 2024
@SimeonC SimeonC force-pushed the update-variables branch 4 times, most recently from 9281d09 to f30d851 Compare November 12, 2024 07:11
@SimeonC SimeonC enabled auto-merge (rebase) November 18, 2024 06:41
SashaShostyr
SashaShostyr previously approved these changes Nov 18, 2024
* We now export Spacing and Border Radius as objects again.
* Switched to using asdf rather than nvm so we can use bun to run typescript files.
* Ad-hoc re-coloring of the Skeleton due to color changes and added a story for it to test

BREAKING CHANGE: All `--primary` variables are now removed, if you needed the value for our logo use `--brand-static` in all other cases use `--brand-primary` which is a light/dark aware purple “primary” color.
@SimeonC SimeonC merged commit 662bd86 into main Nov 20, 2024
10 checks passed
@SimeonC SimeonC deleted the update-variables branch November 20, 2024 02:49
@SimeonC SimeonC added the released This issue/pull request has been released. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants