Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when run with no command given #329

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

jacalata
Copy link
Contributor

@jacalata jacalata commented Jan 8, 2025

e.g "tabcmd --server --site --..." would throw an exception about not having an attribute.
Now it will print out the usage information.

Copy link

github-actions bot commented Jan 8, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py101010 0%
   tabcmd.py141414 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py771515 81%
   server.py1302020 85%
tabcmd/commands/auth
   session.py3604242 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1271616 87%
   datasources_workbooks_views_url_parser.py1401010 93%
   delete_command.py601616 73%
   export_command.py1142525 78%
   get_url_command.py1274747 63%
   publish_command.py872424 72%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py491313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py441010 77%
   list_sites_command.py2922 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2213131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1462323 84%
   localize.py691111 84%
   logger_config.py4266 86%
   tabcmd_controller.py4288 81%
TOTAL271244484% 

@jacalata jacalata merged commit b61e158 into development Jan 8, 2025
18 checks passed
@jacalata jacalata deleted the jac/nice-when-no-command branch January 8, 2025 19:29
print("No command found.")
parser.print_help()
sys.exit(0)

if hasattr("namespace", "logging_level") and namespace.logging_level != logging.INFO:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line need updating too? hasattr(namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants