-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a large number of new localized strings #302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of changes to the dodo code, but it's mostly a) handling file paths better b) moving the 'merge files' step before the 'generate po' step c) automating some processing I did manually in the past to remove lines that caused problems
There is a group of strings I appear to have added manually that was deleted with the new loc file dump, and another group of string keys that are used in code and don't appear in properties. Adding here to not lose them, but hope to find they are not necessary.
Add copyright, fix handling of strings with '=' in them
these should make the process of updating strings straightforward in the future, and create intermediate outputs to help with debugging if it is not. Validated with the windows package only so far.
Removed a duplicate string from extras.properties Adding the newly generated .mo files
and remove test on a string that no longer exists
- replace double quotes with single - cleaner file globs - remove no-op encoding - fix copyright
Also add to automation a step where I replaced two-single-quote chars with one.
anyoung-tableau
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of files changed here are
However the interesting changes are
I've tested the windows package manually on my machine but will be using github runners to test the mac/linux packages.