Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filepath handling in Get command #277

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

jacalata
Copy link
Contributor

@W-13757625 - the command threw an error and failed if the filepath to save to contained a full stop, e.g
c:\users\chevy.chase\

Fixed by using os.path instead of manual parsing. Also added a test to cover the scenario.

@jacalata jacalata added bug Something isn't working 2.0.14 labels Feb 16, 2024
Copy link

github-actions bot commented Feb 16, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py777 0%
   tabcmd.py141414 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py721313 82%
   server.py1262626 79%
tabcmd/commands/auth
   session.py3604242 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1171313 89%
   delete_command.py601616 73%
   export_command.py1282828 78%
   get_url_command.py1896161 68%
   publish_command.py832525 70%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py2844 86%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py441010 77%
   list_sites_command.py3022 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2203030 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1442424 83%
   localize.py6788 88%
   logger_config.py4266 86%
   tabcmd_controller.py3544 89%
TOTAL260744383% 

Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just that one question.

Also the mypy step is throwing this error:
tests/e2e/online_tests.py:314: error: Name "test_list_workbooks" already defined on line 308 [no-redef]

I think that was from a previous change, but we should fix it. (Looks like a copy & paste error.)

@jacalata jacalata force-pushed the jac/w-13757625-filepaths branch from 3b75f3a to 3232509 Compare February 21, 2024 23:52
@jacalata jacalata merged commit 71d36c3 into development Feb 22, 2024
18 checks passed
@jacalata jacalata deleted the jac/w-13757625-filepaths branch February 22, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.14 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants