-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components/webserver): added support for proxification #678
base: develop
Are you sure you want to change the base?
Conversation
Proxy support added by setting the addrs in the `txAdminProxyAddresses` variable separated by `,`. No support for CIDRs as it would require a module and I leave that decision to tabarra. The actual address of the client must be specified in the `x-txadmin-real-ip header`. Example configuration: ``` set txAdminProxyAddresses "104.81.29.xxx, 92.10.23.xxx" ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is look a seems good
Hey @MrSentex thanks for the PR. |
No real reason, I followed the pattern of the rest of the headers as |
I think we better go with XFF, since it will be the zero-config alternative for most reverse proxies. Koa itself has an option for that which can accept an array but must be configured correctly not to be vulnerable to XFF spoofing. |
The safest option I can think of would be to add a header for example: |
But with the current configuration the user should not have to worry. We could raise an alert if the public IP address of the server is in the list of authorised IP addresses. |
The code should also be modified to follow the XFF standard as there may be more than one IP address concatenated. |
Proxy support added by setting the addrs in the
txAdminProxyAddresses
variable separated by,
. No support for CIDRs as it would require a module and I leave that decision to tabarra.The actual address of the client must be specified in the
x-txadmin-real-ip
header.Example configuration: