Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple sheets support #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

multiple sheets support #3

wants to merge 1 commit into from
+274 −1,897

Conversation

gstaron
Copy link

@gstaron gstaron commented Feb 11, 2020

  1. Added support for multiple sheets.
  2. Only 1 composite property for columns, data, sheetname properties.
  3. Get rid of requiring jquery.

Maxtoros
Maxtoros reviewed Apr 28, 2020
View reviewed changes
VueExcelXlsx.vue

let filename = vm.filename + ".xlsx";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to re-add this part, user isn't going to specify the file extension since he's expecting it to be an xlsx.

@majid-saeed
Copy link

any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxtoros Maxtoros Maxtoros left review comments

@arnonrdp arnonrdp arnonrdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gstaron @majid-saeed @Maxtoros @arnonrdp