[frontend] トップページを実装 #114
Merged
[frontend] トップページを実装 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 4b54f18): https://szpp-judge-3776--pr114-feat-frontend-top-2nczn97y.web.app (expires Tue, 10 Oct 2023 20:43:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f8b9d12a855b0fe650d3231cd716db46d79c069 |
h-takeyeah
commented
Oct 8, 2023
| @@ -156,7 +156,7 @@ const SidebarMainPane = ({ | |||
| <SidebarLinkItem text="コンテストトップ" icon={IoHome} href={`${contestRootPath}`} /> | |||
| {contestStarted && ( | |||
| <> | |||
| <SidebarLinkItem text="質問" icon={IoChatboxEllipses} href={`${contestRootPath}/clarifications`} /> | |||
| {/* <SidebarLinkItem text="質問" icon={IoChatboxEllipses} href={`${contestRootPath}/clarifications`} /> */} | |||
There was a problem hiding this comment.
Phase 1ではやらない
h-takeyeah
commented
Oct 8, 2023
| @@ -55,7 +55,7 @@ export const GlobalHeader = ({ | |||
| {contestSlug ? <NavItemLink href={`/contests/${contestSlug}`}>{contestTitle}</NavItemLink> : ( | |||
| <> | |||
| <NavItemLink href="/contests">コンテスト</NavItemLink> | |||
| <NavItemLink href="/tasks">問題</NavItemLink> | |||
| {/* <NavItemLink href="/tasks">問題</NavItemLink> */} | |||
There was a problem hiding this comment.
Phase 1ではやらない
h-takeyeah
commented
Oct 8, 2023
| import { Link } from "../../ui/Link"; | ||
|
|
||
| const ContestBanner = () => { | ||
| const { contests, isLoading, error } = useListContests(); |
There was a problem hiding this comment.
コンテスト全件取得になっているの，問題なので API に絞り込み機能をつけることで解決したいですね 😃
h-takeyeah
commented
Oct 8, 2023
next/image は static export と相性が悪いので使ってこなかったが， unoptimized: true ならば使える(linter に怒られないというだけ)こと が分かったので今後 SSR に移行する可能性も踏まえて置き換える.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
この PR でやること
この PR でやらないこと
ページングや終了済み・開始前などで絞り込めると嬉しいのですが，そこはまた今度．