Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MICROBIN_ETERNAL_PASTA #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix MICROBIN_ETERNAL_PASTA #215

wants to merge 1 commit into from

Conversation

SouthFox-D
Copy link

Is something missing here?

@perfectra1n
Copy link

I really thought I was losing my sanity, thank you for finding this lol.

@surfaceflinger surfaceflinger mentioned this pull request Nov 10, 2023
Merged
13 tasks
@kendofriendo kendofriendo mentioned this pull request Nov 30, 2023
Merged
@zhaobenny zhaobenny mentioned this pull request Feb 23, 2024
Open
@dvdsk
Copy link
Contributor

dvdsk commented Oct 22, 2024

Is this still needed given #260? I applied that to my fork and the expiration dropdown is now working without merging this pr. What is the difference between #260 and this?

@perfectra1n
Copy link

@dvdsk this PR allows for the option "never" to appear when the environment variable MICROBIN_ETERNAL_PASTA=true is provided. #260 fixes the behavior of the "never" option when selected. At least that's what I've gathered by looking at the "Files changed" for a quick minute.

@dvdsk
Copy link
Contributor

dvdsk commented Oct 22, 2024

the strange thing is, in my fork (dev branch): https://github.com/dvdsk/microbin/tree/dev I have merged only #260 and the never option now appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SouthFox-D @perfectra1n @dvdsk